minor #47014 [Dotenv] Run test in a separate process to have clean global state (rmikalkenas)

fabpot · fabpot · commit 8be4d283ed61 · 2022-07-22T15:26:43.000+02:00
This PR was merged into the 6.2 branch. Discussion ---------- [Dotenv] Run test in a separate process to have clean global state | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix #... | License | MIT | Doc PR | symfony/symfony-docs#... A fix to comment: #46502 (comment) cc @chalasr Commits ------- be3782c [Dotenv] Run test in a separate process to have clean global state
diff --git a/src/Symfony/Component/Dotenv/Command/DebugCommand.php b/src/Symfony/Component/Dotenv/Command/DebugCommand.php
@@ -13,6 +13,8 @@
 
 use Symfony\Component\Console\Attribute\AsCommand;
 use Symfony\Component\Console\Command\Command;
+use Symfony\Component\Console\Completion\CompletionInput;
+use Symfony\Component\Console\Completion\CompletionSuggestions;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
@@ -117,6 +119,13 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         return 0;
     }
 
+    public function complete(CompletionInput $input, CompletionSuggestions $suggestions): void
+    {
+        if ($input->mustSuggestArgumentValuesFor('filter')) {
+            $suggestions->suggestValues($this->getAvailableVars());
+        }
+    }
+
     private function getVariables(array $envFiles, ?string $nameFilter): array
     {
         $vars = $this->getAvailableVars();
diff --git a/src/Symfony/Component/Dotenv/Tests/Command/DebugCommandTest.php b/src/Symfony/Component/Dotenv/Tests/Command/DebugCommandTest.php
@@ -12,6 +12,7 @@
 namespace Symfony\Component\Dotenv\Tests\Command;
 
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\Console\Application;
 use Symfony\Component\Console\Helper\FormatterHelper;
 use Symfony\Component\Console\Helper\HelperSet;
 use Symfony\Component\Console\Tester\CommandCompletionTester;
@@ -207,6 +208,9 @@ public function testScenario2InProdEnvWithNameFilterPrefix()
         $this->assertStringContainsString('TEST       1234    1234             1234        0000', $output);
     }
 
+    /**
+     * @runInSeparateProcess
+     */
     public function testCompletion()
     {
         $env = 'prod';
@@ -216,8 +220,10 @@ public function testCompletion()
         (new Dotenv('TEST_ENV_KEY'))->bootEnv($projectDirectory.'/.env');
 
         $command = new DebugCommand($env, $projectDirectory);
-        $tester = new CommandCompletionTester($command);
-        $this->assertSame(['FOO', 'HELLO', 'TEST', 'TEST123'], $tester->complete(['']));
+        $application = new Application();
+        $application->add($command);
+        $tester = new CommandCompletionTester($application->get('debug:dotenv'));
+        $this->assertSame(['FOO', 'TEST'], $tester->complete(['']));
     }
 
     private function executeCommand(string $projectDirectory, string $env, array $input = []): string
