minor #39459 Remove void return type from test methods (OskarStark)

nicolas-grekas · nicolas-grekas · commit 8d6794f6b6fd · 2020-12-11T16:19:13.000+01:00
This PR was merged into the 4.4 branch. Discussion ---------- Remove void return type from test methods | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | --- | License | MIT | Doc PR | --- cc @nicolas-grekas Commits ------- 94f823f Remove void return type from test methods
diff --git a/src/Symfony/Bridge/Twig/Tests/Mime/BodyRendererTest.php b/src/Symfony/Bridge/Twig/Tests/Mime/BodyRendererTest.php
@@ -21,13 +21,13 @@
 
 class BodyRendererTest extends TestCase
 {
-    public function testRenderTextOnly(): void
+    public function testRenderTextOnly()
     {
         $email = $this->prepareEmail('Text', null);
         $this->assertEquals('Text', $email->getBody()->bodyToString());
     }
 
-    public function testRenderHtmlOnly(): void
+    public function testRenderHtmlOnly()
     {
         $html = '<head>head</head><b>HTML</b><style type="text/css">css</style>';
         $email = $this->prepareEmail(null, $html);
@@ -37,7 +37,7 @@ public function testRenderHtmlOnly(): void
         $this->assertEquals(str_replace('=', '=3D', $html), $body->getParts()[1]->bodyToString());
     }
 
-    public function testRenderHtmlOnlyWithTextSet(): void
+    public function testRenderHtmlOnlyWithTextSet()
     {
         $email = $this->prepareEmail(null, '<b>HTML</b>');
         $email->text('Text');
@@ -47,7 +47,7 @@ public function testRenderHtmlOnlyWithTextSet(): void
         $this->assertEquals('<b>HTML</b>', $body->getParts()[1]->bodyToString());
     }
 
-    public function testRenderTextAndHtml(): void
+    public function testRenderTextAndHtml()
     {
         $email = $this->prepareEmail('Text', '<b>HTML</b>');
         $body = $email->getBody();
@@ -56,7 +56,7 @@ public function testRenderTextAndHtml(): void
         $this->assertEquals('<b>HTML</b>', $body->getParts()[1]->bodyToString());
     }
 
-    public function testRenderWithContextReservedEmailEntry(): void
+    public function testRenderWithContextReservedEmailEntry()
     {
         $this->expectException(InvalidArgumentException::class);
         $this->prepareEmail('Text', '', ['email' => 'reserved!']);
diff --git a/src/Symfony/Component/HttpKernel/Tests/KernelTest.php b/src/Symfony/Component/HttpKernel/Tests/KernelTest.php
@@ -663,7 +663,7 @@ public function testKernelStartTimeIsResetWhileBootingAlreadyBootedKernel()
         $this->assertGreaterThan($preReBoot, $kernel->getStartTime());
     }
 
-    public function testAnonymousKernelGeneratesValidContainerClass(): void
+    public function testAnonymousKernelGeneratesValidContainerClass()
     {
         $kernel = new class('test', true) extends Kernel {
             public function registerBundles(): iterable
diff --git a/src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php b/src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php
@@ -396,7 +396,7 @@ public function constructorTypesProvider(): array
     /**
      * @requires PHP 7.4
      */
-    public function testTypedProperties(): void
+    public function testTypedProperties()
     {
         $this->assertEquals([new Type(Type::BUILTIN_TYPE_OBJECT, false, Dummy::class)], $this->extractor->getTypes(Php74Dummy::class, 'dummy'));
         $this->assertEquals([new Type(Type::BUILTIN_TYPE_BOOL, true)], $this->extractor->getTypes(Php74Dummy::class, 'nullableBoolProp'));

Original file line number	Diff line number	Diff line change
`@@ -21,13 +21,13 @@`
`21`	`21`
`22`	`22`	`class BodyRendererTest extends TestCase`
`23`	`23`	`{`
`24`		`- public function testRenderTextOnly(): void`
	`24`	`+ public function testRenderTextOnly()`
`25`	`25`	`{`
`26`	`26`	`$email = $this->prepareEmail('Text', null);`
`27`	`27`	`$this->assertEquals('Text', $email->getBody()->bodyToString());`
`28`	`28`	`}`
`29`	`29`
`30`		`- public function testRenderHtmlOnly(): void`
	`30`	`+ public function testRenderHtmlOnly()`
`31`	`31`	`{`
`32`	`32`	`$html = '<head>head</head><b>HTML</b><style type="text/css">css</style>';`
`33`	`33`	`$email = $this->prepareEmail(null, $html);`
`@@ -37,7 +37,7 @@ public function testRenderHtmlOnly(): void`
`37`	`37`	`$this->assertEquals(str_replace('=', '=3D', $html), $body->getParts()[1]->bodyToString());`
`38`	`38`	`}`
`39`	`39`
`40`		`- public function testRenderHtmlOnlyWithTextSet(): void`
	`40`	`+ public function testRenderHtmlOnlyWithTextSet()`
`41`	`41`	`{`
`42`	`42`	`$email = $this->prepareEmail(null, '<b>HTML</b>');`
`43`	`43`	`$email->text('Text');`
`@@ -47,7 +47,7 @@ public function testRenderHtmlOnlyWithTextSet(): void`
`47`	`47`	`$this->assertEquals('<b>HTML</b>', $body->getParts()[1]->bodyToString());`
`48`	`48`	`}`
`49`	`49`
`50`		`- public function testRenderTextAndHtml(): void`
	`50`	`+ public function testRenderTextAndHtml()`
`51`	`51`	`{`
`52`	`52`	`$email = $this->prepareEmail('Text', '<b>HTML</b>');`
`53`	`53`	`$body = $email->getBody();`
`@@ -56,7 +56,7 @@ public function testRenderTextAndHtml(): void`
`56`	`56`	`$this->assertEquals('<b>HTML</b>', $body->getParts()[1]->bodyToString());`
`57`	`57`	`}`
`58`	`58`
`59`		`- public function testRenderWithContextReservedEmailEntry(): void`
	`59`	`+ public function testRenderWithContextReservedEmailEntry()`
`60`	`60`	`{`
`61`	`61`	`$this->expectException(InvalidArgumentException::class);`
`62`	`62`	`$this->prepareEmail('Text', '', ['email' => 'reserved!']);`
Original file line number	Diff line number	Diff line change
`@@ -663,7 +663,7 @@ public function testKernelStartTimeIsResetWhileBootingAlreadyBootedKernel()`
`663`	`663`	`$this->assertGreaterThan($preReBoot, $kernel->getStartTime());`
`664`	`664`	`}`
`665`	`665`
`666`		`- public function testAnonymousKernelGeneratesValidContainerClass(): void`
	`666`	`+ public function testAnonymousKernelGeneratesValidContainerClass()`
`667`	`667`	`{`
`668`	`668`	`$kernel = new class('test', true) extends Kernel {`
`669`	`669`	`public function registerBundles(): iterable`
Original file line number	Diff line number	Diff line change
`@@ -396,7 +396,7 @@ public function constructorTypesProvider(): array`
`396`	`396`	`/**`
`397`	`397`	`* @requires PHP 7.4`
`398`	`398`	`*/`
`399`		`- public function testTypedProperties(): void`
	`399`	`+ public function testTypedProperties()`
`400`	`400`	`{`
`401`	`401`	`$this->assertEquals([new Type(Type::BUILTIN_TYPE_OBJECT, false, Dummy::class)], $this->extractor->getTypes(Php74Dummy::class, 'dummy'));`
`402`	`402`	`$this->assertEquals([new Type(Type::BUILTIN_TYPE_BOOL, true)], $this->extractor->getTypes(Php74Dummy::class, 'nullableBoolProp'));`