bug #35125 [Translator] fix performance issue in MessageCatalogue and catalogue operations (ArtemBrovko)

nicolas-grekas · nicolas-grekas · commit 8e9aafc84fc7 · 2019-12-31T15:31:48.000+01:00
This PR was merged into the 3.4 branch. Discussion ---------- [Translator] fix performance issue in MessageCatalogue and catalogue operations | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - In our project we use lots of catalogue operations during importing of translations to our system and we ran into performance issue. Code profiler showed lots or `array_replace` calls in [MessageCatalogue::add](https://github.com/symfony/symfony/blob/3.4/src/Symfony/Component/Translation/MessageCatalogue.php#L128) method. This method is actually called by [MessageCatalogue::set](https://github.com/symfony/symfony/blob/3.4/src/Symfony/Component/Translation/MessageCatalogue.php#L70), which is quite an overkill, because `MessageCatalogue::set` is meant to set only one translation at a time. Method was reworked. `MergeOperation` and `TargetOperation` was reworked as well to use this improved `MessageCatalogue::set` method instead of constructing array with only one translation and passing it to `MessageCatalogue::add` method. Table shows execution time before and after | | Time in seconds (avg. of 10 executions) ----------- | ------ Before | 50 After | 8 Looks like 4.* and 5.* versions can also be improved by the same changes.  Commits ------- 5179af4 [Translator] Performance improvement in MessageCatalogue and catalogue operations.
diff --git a/src/Symfony/Component/Translation/MessageCatalogue.php b/src/Symfony/Component/Translation/MessageCatalogue.php
@@ -130,7 +130,9 @@ public function add($messages, $domain = 'messages')
         if (!isset($this->messages[$domain])) {
             $this->messages[$domain] = $messages;
         } else {
-            $this->messages[$domain] = array_replace($this->messages[$domain], $messages);
+            foreach ($messages as $id => $message) {
+                $this->messages[$domain][$id] = $message;
+            }
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,9 @@ public function add($messages, $domain = 'messages')`
`130`	`130`	`if (!isset($this->messages[$domain])) {`
`131`	`131`	`$this->messages[$domain] = $messages;`
`132`	`132`	`} else {`
`133`		`- $this->messages[$domain] = array_replace($this->messages[$domain], $messages);`
	`133`	`+ foreach ($messages as $id => $message) {`
	`134`	`+ $this->messages[$domain][$id] = $message;`
	`135`	`+ }`
`134`	`136`	`}`
`135`	`137`	`}`
`136`	`138`