Revert "feature #21038 [FrameworkBundle] deprecated cache:clear with warmup (fabpot)"

nicolas-grekas · nicolas-grekas · commit 90099706c635 · 2017-08-08T08:44:34.000+02:00
This reverts commit 3495b35, reversing changes made to 7f7b897.
diff --git a/UPGRADE-3.3.md b/UPGRADE-3.3.md
@@ -165,9 +165,6 @@ Form
 FrameworkBundle
 ---------------
 
- * The `cache:clear` command should always be called with the `--no-warmup` option.
-   Warmup should be done via the `cache:warmup` command.
-
  * [BC BREAK] The "framework.trusted_proxies" configuration option and the corresponding "kernel.trusted_proxies"
    parameter have been removed. Use the Request::setTrustedProxies() method in your front controller instead.
 
diff --git a/UPGRADE-4.0.md b/UPGRADE-4.0.md
@@ -223,9 +223,6 @@ Form
 FrameworkBundle
 ---------------
 
- * The `cache:clear` command does not warmup the cache anymore. Warmup should
-   be done via the `cache:warmup` command.
-
  * The "framework.trusted_proxies" configuration option and the corresponding "kernel.trusted_proxies" parameter have been removed. Use the `Request::setTrustedProxies()` method in your front controller instead.
 
  * The default value of the `framework.workflows.[name].type` configuration options is now `state_machine`.
diff --git a/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md b/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md
@@ -14,7 +14,6 @@ CHANGELOG
    the same helpers as the `Controller` class, but does not allow accessing the dependency
    injection container, in order to encourage explicit dependency declarations.
  * Added support for the `controller.service_arguments` tag, for injecting services into controllers' actions
- * Deprecated `cache:clear` with warmup (always call it with `--no-warmup`)
  * Changed default configuration for
    assets/forms/validation/translation/serialization/csrf from `canBeEnabled()` to
    `canBeDisabled()` when Flex is used
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/CacheClearCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/CacheClearCommand.php
@@ -77,12 +77,6 @@ protected function execute(InputInterface $input, OutputInterface $output)
         if ($input->getOption('no-warmup')) {
             $filesystem->rename($realCacheDir, $oldCacheDir);
         } else {
-            $warning = 'Calling cache:clear without the --no-warmup option is deprecated since version 3.3. Cache warmup should be done with the cache:warmup command instead.';
-
-            @trigger_error($warning, E_USER_DEPRECATED);
-
-            $io->warning($warning);
-
             $this->warmupCache($input, $output, $realCacheDir, $oldCacheDir);
         }
 
@@ -132,8 +126,6 @@ private function warmupCache(InputInterface $input, OutputInterface $output, $re
      * @param string $warmupDir
      * @param string $realCacheDir
      * @param bool   $enableOptionalWarmers
-     *
-     * @internal to be removed in 4.0
      */
     protected function warmup($warmupDir, $realCacheDir, $enableOptionalWarmers = true)
     {
@@ -200,8 +192,6 @@ protected function warmup($warmupDir, $realCacheDir, $enableOptionalWarmers = tr
      * @param string          $warmupDir
      *
      * @return KernelInterface
-     *
-     * @internal to be removed in 4.0
      */
     protected function getTempKernel(KernelInterface $parent, $namespace, $parentClass, $warmupDir)
     {
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Command/CacheClearCommand/CacheClearCommandTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Command/CacheClearCommand/CacheClearCommandTest.php
@@ -43,9 +43,6 @@ protected function tearDown()
         $this->fs->remove($this->rootDir);
     }
 
-    /**
-     * @group legacy
-     */
     public function testCacheIsFreshAfterCacheClearedWithWarmup()
     {
         $input = new ArrayInput(array('cache:clear'));

Original file line number	Diff line number	Diff line change
`@@ -43,9 +43,6 @@ protected function tearDown()`
`43`	`43`	`$this->fs->remove($this->rootDir);`
`44`	`44`	`}`
`45`	`45`
`46`		`- /**`
`47`		`- * @group legacy`
`48`		`- */`
`49`	`46`	`public function testCacheIsFreshAfterCacheClearedWithWarmup()`
`50`	`47`	`{`
`51`	`48`	`$input = new ArrayInput(array('cache:clear'));`