Don't use named params as MySQLi doesn't support them

duncan3dc · duncan3dc · commit 90752a2cdc2e · 2020-01-23T13:42:38.000Z
diff --git a/src/Symfony/Component/Lock/Store/PdoStore.php b/src/Symfony/Component/Lock/Store/PdoStore.php
@@ -31,6 +31,9 @@
  * To ensure locks don't expire prematurely; the TTLs should be set with enough
  * extra time to account for any clock drift between nodes.
  *
+ * CAUTION: The queries in this class must not use named params
+ * because the mysqli driver does not support them.
+ *
  * @author Jérémy Derussé <jeremy@derusse.com>
  */
 class PdoStore implements StoreInterface
@@ -116,11 +119,11 @@ public function save(Key $key)
     {
         $key->reduceLifetime($this->initialTtl);
 
-        $sql = "INSERT INTO $this->table ($this->idCol, $this->tokenCol, $this->expirationCol) VALUES (:id, :token, {$this->getCurrentTimestampStatement()} + $this->initialTtl)";
+        $sql = "INSERT INTO $this->table ($this->idCol, $this->tokenCol, $this->expirationCol) VALUES (?, ?, {$this->getCurrentTimestampStatement()} + $this->initialTtl)";
         $stmt = $this->getConnection()->prepare($sql);
 
-        $stmt->bindValue(':id', $this->getHashedKey($key));
-        $stmt->bindValue(':token', $this->getUniqueToken($key));
+        $stmt->bindValue(1, $this->getHashedKey($key));
+        $stmt->bindValue(2, $this->getUniqueToken($key));
 
         try {
             $stmt->execute();
@@ -158,13 +161,13 @@ public function putOffExpiration(Key $key, $ttl)
 
         $key->reduceLifetime($ttl);
 
-        $sql = "UPDATE $this->table SET $this->expirationCol = {$this->getCurrentTimestampStatement()} + $ttl, $this->tokenCol = :token1 WHERE $this->idCol = :id AND ($this->tokenCol = :token2 OR $this->expirationCol <= {$this->getCurrentTimestampStatement()})";
+        $sql = "UPDATE $this->table SET $this->expirationCol = {$this->getCurrentTimestampStatement()} + $ttl, $this->tokenCol = ? WHERE $this->idCol = ? AND ($this->tokenCol = ? OR $this->expirationCol <= {$this->getCurrentTimestampStatement()})";
         $stmt = $this->getConnection()->prepare($sql);
 
         $uniqueToken = $this->getUniqueToken($key);
-        $stmt->bindValue(':id', $this->getHashedKey($key));
-        $stmt->bindValue(':token1', $uniqueToken);
-        $stmt->bindValue(':token2', $uniqueToken);
+        $stmt->bindValue(1, $uniqueToken);
+        $stmt->bindValue(2, $this->getHashedKey($key));
+        $stmt->bindValue(3, $uniqueToken);
         $stmt->execute();
 
         // If this method is called twice in the same second, the row wouldn't be updated. We have to call exists to know if we are the owner
@@ -180,11 +183,11 @@ public function putOffExpiration(Key $key, $ttl)
      */
     public function delete(Key $key)
     {
-        $sql = "DELETE FROM $this->table WHERE $this->idCol = :id AND $this->tokenCol = :token";
+        $sql = "DELETE FROM $this->table WHERE $this->idCol = ? AND $this->tokenCol = ?";
         $stmt = $this->getConnection()->prepare($sql);
 
-        $stmt->bindValue(':id', $this->getHashedKey($key));
-        $stmt->bindValue(':token', $this->getUniqueToken($key));
+        $stmt->bindValue(1, $this->getHashedKey($key));
+        $stmt->bindValue(2, $this->getUniqueToken($key));
         $stmt->execute();
     }
 
@@ -193,11 +196,11 @@ public function delete(Key $key)
      */
     public function exists(Key $key)
     {
-        $sql = "SELECT 1 FROM $this->table WHERE $this->idCol = :id AND $this->tokenCol = :token AND $this->expirationCol > {$this->getCurrentTimestampStatement()}";
+        $sql = "SELECT 1 FROM $this->table WHERE $this->idCol = ? AND $this->tokenCol = ? AND $this->expirationCol > {$this->getCurrentTimestampStatement()}";
         $stmt = $this->getConnection()->prepare($sql);
 
-        $stmt->bindValue(':id', $this->getHashedKey($key));
-        $stmt->bindValue(':token', $this->getUniqueToken($key));
+        $stmt->bindValue(1, $this->getHashedKey($key));
+        $stmt->bindValue(2, $this->getUniqueToken($key));
         $stmt->execute();
 
         return (bool) $stmt->fetchColumn();
