bug #26727 [HttpCache] Unlink tmp file on error (Chansig)

fabpot · fabpot · commit 913c1fd01161 · 2018-04-01T10:29:22.000+02:00
This PR was merged into the 2.7 branch. Discussion ---------- [HttpCache] Unlink tmp file on error | Q | A | ------------- | --- | Branch? | 2.7 up to 4.0 for bug fixes  | Bug fix? | yes | New feature? |no  | BC breaks? | no  | Deprecations? | no  | Tests pass? | yes  | Fixed tickets | #22719  | License | MIT | Doc PR |  The tempnam function creates a unique temporary file for each call to a page to be cached, and if the temporary folder passed as an argument is not writable, tempnam will use /tmp. _Note: If PHP cannot create a file in the specified dir parameter, it falls back on the system default. On NTFS this also happens if the specified dir contains more than 65534 files. http://php.net/manual/en/function.tempnam.php_ Therefore, as soon as the HttpCache cache is no longer writable, the /tmp fills up fairly quickly, tempnam being called on every page (since no page cache) and creating a new unique file in /tmp. See #22719 Commits ------- c9a0355 [HttpCache] Unlink tmp file on error
diff --git a/src/Symfony/Component/HttpKernel/HttpCache/Store.php b/src/Symfony/Component/HttpKernel/HttpCache/Store.php
@@ -387,16 +387,22 @@ private function save($key, $data)
 
             $tmpFile = tempnam(dirname($path), basename($path));
             if (false === $fp = @fopen($tmpFile, 'wb')) {
+                @unlink($tmpFile);
+
                 return false;
             }
             @fwrite($fp, $data);
             @fclose($fp);
 
             if ($data != file_get_contents($tmpFile)) {
+                @unlink($tmpFile);
+
                 return false;
             }
 
             if (false === @rename($tmpFile, $path)) {
+                @unlink($tmpFile);
+
                 return false;
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -387,16 +387,22 @@ private function save($key, $data)`
`387`	`387`
`388`	`388`	`$tmpFile = tempnam(dirname($path), basename($path));`
`389`	`389`	`if (false === $fp = @fopen($tmpFile, 'wb')) {`
	`390`	`+ @unlink($tmpFile);`
	`391`	`+`
`390`	`392`	`return false;`
`391`	`393`	`}`
`392`	`394`	`@fwrite($fp, $data);`
`393`	`395`	`@fclose($fp);`
`394`	`396`
`395`	`397`	`if ($data != file_get_contents($tmpFile)) {`
	`398`	`+ @unlink($tmpFile);`
	`399`	`+`
`396`	`400`	`return false;`
`397`	`401`	`}`
`398`	`402`
`399`	`403`	`if (false === @rename($tmpFile, $path)) {`
	`404`	`+ @unlink($tmpFile);`
	`405`	`+`
`400`	`406`	`return false;`
`401`	`407`	`}`
`402`	`408`	`}`