[Cache] Prevent notice on case matching metadata trick

bastnic · bastnic · commit 941f9e8f5b2f · 2020-12-10T00:19:33.000+01:00
On saving an array of one element with a int key of strlen 10
it matches the first conditions of the trick used to save metadata.

&gt; Notice: Trying to access array offset on value of type int

Casting it to string fixes it.
diff --git a/src/Symfony/Component/Cache/Adapter/AbstractAdapter.php b/src/Symfony/Component/Cache/Adapter/AbstractAdapter.php
@@ -51,7 +51,7 @@ static function ($key, $value, $isHit) {
                 // Detect wrapped values that encode for their expiry and creation duration
                 // For compactness, these values are packed in the key of an array using
                 // magic numbers in the form 9D-..-..-..-..-00-..-..-..-5F
-                if (\is_array($v) && 1 === \count($v) && 10 === \strlen($k = key($v)) && "\x9D" === $k[0] && "\0" === $k[5] && "\x5F" === $k[9]) {
+                if (\is_array($v) && 1 === \count($v) && 10 === \strlen($k = (string) key($v)) && "\x9D" === $k[0] && "\0" === $k[5] && "\x5F" === $k[9]) {
                     $item->value = $v[$k];
                     $v = unpack('Ve/Nc', substr($k, 1, -1));
                     $item->metadata[CacheItem::METADATA_EXPIRY] = $v['e'] + CacheItem::METADATA_EXPIRY_OFFSET;
diff --git a/src/Symfony/Component/Cache/Adapter/ProxyAdapter.php b/src/Symfony/Component/Cache/Adapter/ProxyAdapter.php
@@ -59,7 +59,7 @@ static function ($key, $innerItem) use ($poolHash) {
                 // Detect wrapped values that encode for their expiry and creation duration
                 // For compactness, these values are packed in the key of an array using
                 // magic numbers in the form 9D-..-..-..-..-00-..-..-..-5F
-                if (\is_array($v) && 1 === \count($v) && 10 === \strlen($k = key($v)) && "\x9D" === $k[0] && "\0" === $k[5] && "\x5F" === $k[9]) {
+                if (\is_array($v) && 1 === \count($v) && 10 === \strlen($k = (string) key($v)) && "\x9D" === $k[0] && "\0" === $k[5] && "\x5F" === $k[9]) {
                     $item->value = $v[$k];
                     $v = unpack('Ve/Nc', substr($k, 1, -1));
                     $item->metadata[CacheItem::METADATA_EXPIRY] = $v['e'] + CacheItem::METADATA_EXPIRY_OFFSET;
diff --git a/src/Symfony/Component/Cache/Tests/Adapter/AdapterTestCase.php b/src/Symfony/Component/Cache/Tests/Adapter/AdapterTestCase.php
@@ -272,6 +272,30 @@ public function testClearPrefix()
         $this->assertFalse($cache->hasItem('foobar'));
         $this->assertTrue($cache->hasItem('barfoo'));
     }
+
+    public function testWeirdDataMatchingMetadataWrappedValues()
+    {
+        if (isset($this->skippedTests[__FUNCTION__])) {
+            $this->markTestSkipped($this->skippedTests[__FUNCTION__]);
+        }
+
+        $cache = $this->createCachePool(0, __FUNCTION__);
+        $cache->clear();
+
+        $item = $cache->getItem('foobar');
+
+        // it should be an array containing only one element
+        // with key having a strlen of 10.
+        $weirdDataMatchingMedatataWrappedValue = [
+            1234567890 => [
+                1
+            ]
+        ];
+
+        $cache->save($item->set($weirdDataMatchingMedatataWrappedValue));
+
+        $this->assertTrue($cache->hasItem('foobar'));
+    }
 }
 
 class NotUnserializable
