[TwigBundle] removed the Container dependency on ActionsExtension

fabpot · fabpot · commit 9427bce33c0a · 2015-01-04T11:10:15.000+01:00
diff --git a/src/Symfony/Bundle/TwigBundle/DependencyInjection/Compiler/ExtensionPass.php b/src/Symfony/Bundle/TwigBundle/DependencyInjection/Compiler/ExtensionPass.php
@@ -27,6 +27,10 @@ public function process(ContainerBuilder $container)
             $container->getDefinition('twig.loader.filesystem')->addMethodCall('addPath', array(dirname(dirname($reflClass->getFileName())).'/Resources/views/Form'));
         }
 
+        if ($container->has('fragment.handler')) {
+            $container->getDefinition('twig.extension.actions')->addTag('twig.extension');
+        }
+
         if ($container->has('translator')) {
             $container->getDefinition('twig.extension.trans')->addTag('twig.extension');
         }
diff --git a/src/Symfony/Bundle/TwigBundle/Extension/ActionsExtension.php b/src/Symfony/Bundle/TwigBundle/Extension/ActionsExtension.php
@@ -12,8 +12,8 @@
 namespace Symfony\Bundle\TwigBundle\Extension;
 
 use Symfony\Bundle\TwigBundle\TokenParser\RenderTokenParser;
-use Symfony\Bundle\FrameworkBundle\Templating\Helper\ActionsHelper;
 use Symfony\Component\DependencyInjection\ContainerInterface;
+use Symfony\Component\HttpKernel\Fragment\FragmentHandler;
 
 /**
  * Twig extension for Symfony actions helper.
@@ -24,16 +24,26 @@
  */
 class ActionsExtension extends \Twig_Extension
 {
-    private $container;
+    private $handler;
 
     /**
-     * Constructor.
+     * @param FragmentHandler|ContainerInterface $handler
      *
-     * @param ContainerInterface $container The service container
+     * @deprecated Passing a ContainerInterface as a first argument is deprecated as of 2.7 and will be removed in 3.0.
      */
-    public function __construct(ContainerInterface $container)
+    public function __construct($handler)
     {
-        $this->container = $container;
+        if ($handler instanceof FragmentHandler) {
+            $this->handler = $handler;
+        } elseif ($handler instanceof ContainerInterface) {
+            trigger_error(sprintf('The ability to pass a ContainerInterface instance as a first argument to %s was deprecated in 2.7 and will be removed in 3.0. Please, pass a FragmentHandler instance instead.', __METHOD__), E_USER_DEPRECATED);
+
+            $this->handler = $handler->get('fragment.handler');
+        } else {
+            throw new \BadFunctionCallException(sprintf('%s takes a FragmentHandler or a ContainerInterface object as its first argument.', __METHOD__));
+        }
+
+        $this->handler = $handler;
     }
 
     /**
@@ -42,11 +52,14 @@ public function __construct(ContainerInterface $container)
      * @param string $uri     A URI
      * @param array  $options An array of options
      *
-     * @see ActionsHelper::render()
+     * @see FragmentHandler::render()
      */
     public function renderUri($uri, array $options = array())
     {
-        return $this->container->get('templating.helper.actions')->render($uri, $options);
+        $strategy = isset($options['strategy']) ? $options['strategy'] : 'inline';
+        unset($options['strategy']);
+
+        return $this->handler->render($uri, $strategy, $options);
     }
 
     /**
diff --git a/src/Symfony/Bundle/TwigBundle/Resources/config/twig.xml b/src/Symfony/Bundle/TwigBundle/Resources/config/twig.xml
@@ -71,8 +71,7 @@
         </service>
 
         <service id="twig.extension.actions" class="%twig.extension.actions.class%" public="false">
-            <tag name="twig.extension" />
-            <argument type="service" id="service_container" />
+            <argument type="service" id="fragment.handler" />
         </service>
 
         <service id="twig.extension.code" class="%twig.extension.code.class%" public="false">

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,10 @@ public function process(ContainerBuilder $container)`
`27`	`27`	`$container->getDefinition('twig.loader.filesystem')->addMethodCall('addPath', array(dirname(dirname($reflClass->getFileName())).'/Resources/views/Form'));`
`28`	`28`	`}`
`29`	`29`
	`30`	`+ if ($container->has('fragment.handler')) {`
	`31`	`+ $container->getDefinition('twig.extension.actions')->addTag('twig.extension');`
	`32`	`+ }`
	`33`	`+`
`30`	`34`	`if ($container->has('translator')) {`
`31`	`35`	`$container->getDefinition('twig.extension.trans')->addTag('twig.extension');`
`32`	`36`	`}`