[DomCrawler] Add argument $default to Crawler::attr()

nicolas-grekas · nicolas-grekas · commit 94af00ef3d95 · 2023-08-17T17:52:53.000+02:00
diff --git a/UPGRADE-7.0.md b/UPGRADE-7.0.md
@@ -156,6 +156,7 @@ DomCrawler
 ----------
 
  * Add argument `$normalizeWhitespace` to `Crawler::innerText()`
+ * Add argument `$default` to `Crawler::attr()`
 
 ExpressionLanguage
 ------------------
diff --git a/src/Symfony/Component/DomCrawler/CHANGELOG.md b/src/Symfony/Component/DomCrawler/CHANGELOG.md
@@ -5,6 +5,7 @@ CHANGELOG
 ---
 
  * Add argument `$normalizeWhitespace` to `Crawler::innerText()`
+ * Add argument `$default` to `Crawler::attr()`
 
 6.4
 ---
diff --git a/src/Symfony/Component/DomCrawler/Crawler.php b/src/Symfony/Component/DomCrawler/Crawler.php
@@ -504,9 +504,8 @@ public function children(string $selector = null): static
      *
      * @throws \InvalidArgumentException When current node is empty
      */
-    public function attr(string $attribute/* , string $default = null */): ?string
+    public function attr(string $attribute, string $default = null): ?string
     {
-        $default = \func_num_args() > 1 ? func_get_arg(1) : null;
         if (!$this->nodes) {
             if (null !== $default) {
                 return $default;

Original file line number	Diff line number	Diff line change
`@@ -504,9 +504,8 @@ public function children(string $selector = null): static`
`504`	`504`	`*`
`505`	`505`	`* @throws \InvalidArgumentException When current node is empty`
`506`	`506`	`*/`
`507`		`- public function attr(string $attribute/* , string $default = null */): ?string`
	`507`	`+ public function attr(string $attribute, string $default = null): ?string`
`508`	`508`	`{`
`509`		`- $default = \func_num_args() > 1 ? func_get_arg(1) : null;`
`510`	`509`	`if (!$this->nodes) {`
`511`	`510`	`if (null !== $default) {`
`512`	`511`	`return $default;`