[Cache] Optimize caching of tags

sbelyshkin · sbelyshkin · commit 9763ed08ee23 · 2022-04-17T21:56:41.000+07:00
diff --git a/src/Symfony/Component/Cache/Adapter/TagAwareAdapter.php b/src/Symfony/Component/Cache/Adapter/TagAwareAdapter.php
@@ -79,8 +79,7 @@ static function (array $items, array $itemTags) {
         );
         self::$setTagVersions ??= \Closure::bind(
             static function (array $items, array $tagVersions) {
-                $now = null;
-                foreach ($items as $key => $item) {
+                foreach ($items as $item) {
                     $item->newMetadata[CacheItem::METADATA_TAGS] = array_intersect_key($tagVersions, $item->newMetadata[CacheItem::METADATA_TAGS] ?? []);
                 }
             },
@@ -343,14 +342,16 @@ public function __destruct()
     private function getTagVersions(array $tagsByKey, bool $persistTags): array
     {
         $tagVersions = [];
-        $fetchTagVersions = false;
+        $fetchTagVersions = $persistTags;
 
         foreach ($tagsByKey as $tags) {
             $tagVersions += $tags;
-
+            if ($fetchTagVersions) {
+                continue;
+            }
             foreach ($tags as $tag => $version) {
                 if ($tagVersions[$tag] !== $version) {
-                    unset($this->knownTagVersions[$tag]);
+                    $fetchTagVersions = true;
                 }
             }
         }
@@ -364,38 +365,39 @@ private function getTagVersions(array $tagsByKey, bool $persistTags): array
         foreach ($tagVersions as $tag => $version) {
             $tags[$tag.static::TAGS_PREFIX] = $tag;
             $knownTagVersion = $this->knownTagVersions[$tag] ?? [0, null];
-            if ($fetchTagVersions || $knownTagVersion[1] !== $version || $now - $knownTagVersion[0] >= $this->knownTagVersionsTtl) {
-                // reuse previously fetched tag versions up to the ttl
-                $fetchTagVersions = true;
-            }
             unset($this->knownTagVersions[$tag]); // For LRU tracking
-            if ([0, null] !== $knownTagVersion) {
-                $this->knownTagVersions[$tag] = $knownTagVersion;
+            if ($fetchTagVersions || $knownTagVersion[1] !== $version || $now > $knownTagVersion[0]) {
+                // reuse previously fetched tag versions until the expiration
+                $fetchTagVersions = true;
+                continue;
             }
+            $this->knownTagVersions[$tag] = $knownTagVersion;
         }
 
         if (!$fetchTagVersions) {
             return $tagVersions;
         }
 
+        if (\count($this->knownTagVersions) > self::MAX_NUMBER_OF_KNOWN_TAG_VERSIONS) {
+            array_splice($this->knownTagVersions, 0, \count($this->knownTagVersions) >> 1);
+        }
+
         $newTags = [];
         $newVersion = null;
+        $expiration = $now + $this->knownTagVersionsTtl;
         foreach ($this->tags->getItems(array_keys($tags)) as $tag => $version) {
-            if (!$version->isHit()) {
+            if ($persistTags && !$version->isHit()) {
                 $newTags[$tag] = $version->set($newVersion ??= random_bytes(6));
             }
-            $tagVersions[$tag = $tags[$tag]] = $version->get();
-            $this->knownTagVersions[$tag] = [$now, $tagVersions[$tag]];
+            if ($tagVersions[$tag = $tags[$tag]] = $version->get()) {
+                $this->knownTagVersions[$tag] = [$expiration, $tagVersions[$tag]];
+            }
         }
 
-        if ($newTags && $persistTags) {
+        if ($newTags) {
             (self::$saveTags)($this->tags, $newTags);
         }
 
-        if (\count($this->knownTagVersions) > $maxTags = max(self::MAX_NUMBER_OF_KNOWN_TAG_VERSIONS, \count($newTags) << 1)) {
-            array_splice($this->knownTagVersions, 0, $maxTags >> 1);
-        }
-
         return $tagVersions;
     }
 }
diff --git a/src/Symfony/Component/Cache/Tests/Adapter/TagAwareAdapterTest.php b/src/Symfony/Component/Cache/Tests/Adapter/TagAwareAdapterTest.php
@@ -67,15 +67,18 @@ public function testKnownTagVersionsTtl()
 
         $pool->save($item);
         $this->assertTrue($pool->getItem('foo')->isHit());
-        $this->assertTrue($pool->getItem('foo')->isHit());
 
-        sleep(20);
+        $tagsPool->deleteItem('baz'.TagAwareAdapter::TAGS_PREFIX); // tag invalidation
 
-        $this->assertTrue($pool->getItem('foo')->isHit());
+        $this->assertTrue($pool->getItem('foo')->isHit()); // known tag version is used
 
-        sleep(5);
+        sleep(10);
 
-        $this->assertTrue($pool->getItem('foo')->isHit());
+        $this->assertTrue($pool->getItem('foo')->isHit()); // known tag version is still used
+
+        sleep(1);
+
+        $this->assertFalse($pool->getItem('foo')->isHit()); // known tag version has expired
     }
 
     public function testInvalidateTagsWithArrayAdapter()
