[SecurityBundle] Fix authenticator existence check in Security::login()

chalasr · chalasr · commit 97fe54d64e5a · 2022-12-11T18:35:51.000+01:00
diff --git a/src/Symfony/Bundle/SecurityBundle/Security.php b/src/Symfony/Bundle/SecurityBundle/Security.php
@@ -116,7 +116,7 @@ public function logout(bool $validateCsrfToken = true): ?Response
 
     private function getAuthenticator(?string $authenticatorName, string $firewallName): AuthenticatorInterface
     {
-        if (!\array_key_exists($firewallName, $this->authenticators)) {
+        if (!isset($this->authenticators[$firewallName])) {
             throw new LogicException(sprintf('No authenticators found for firewall "%s".', $firewallName));
         }
 
diff --git a/src/Symfony/Bundle/SecurityBundle/Tests/SecurityTest.php b/src/Symfony/Bundle/SecurityBundle/Tests/SecurityTest.php
@@ -169,6 +169,38 @@ public function testLogin()
         $security->login($user);
     }
 
+    public function testLoginWithoutAuthenticatorThrows()
+    {
+        $request = new Request();
+        $authenticator = $this->createMock(AuthenticatorInterface::class);
+        $requestStack = $this->createMock(RequestStack::class);
+        $firewallMap = $this->createMock(FirewallMap::class);
+        $firewall = new FirewallConfig('main', 'main');
+        $user = $this->createMock(UserInterface::class);
+        $userChecker = $this->createMock(UserCheckerInterface::class);
+
+        $container = $this->createMock(ContainerInterface::class);
+        $container
+            ->expects($this->atLeastOnce())
+            ->method('get')
+            ->willReturnMap([
+                ['request_stack', $requestStack],
+                ['security.firewall.map', $firewallMap],
+                ['security.user_checker', $userChecker],
+            ])
+        ;
+
+        $requestStack->expects($this->once())->method('getCurrentRequest')->willReturn($request);
+        $firewallMap->expects($this->once())->method('getFirewallConfig')->willReturn($firewall);
+
+        $security = new Security($container, ['main' => null]);
+
+        $this->expectException(\LogicException::class);
+        $this->expectExceptionMessage('No authenticators found for firewall "main".');
+
+        $security->login($user);
+    }
+
     public function testLogout()
     {
         $request = new Request();

Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,7 @@ public function logout(bool $validateCsrfToken = true): ?Response`
`116`	`116`
`117`	`117`	`private function getAuthenticator(?string $authenticatorName, string $firewallName): AuthenticatorInterface`
`118`	`118`	`{`
`119`		`- if (!\array_key_exists($firewallName, $this->authenticators)) {`
	`119`	`+ if (!isset($this->authenticators[$firewallName])) {`
`120`	`120`	`throw new LogicException(sprintf('No authenticators found for firewall "%s".', $firewallName));`
`121`	`121`	`}`
`122`	`122`