fixup! Prevent ProgressBar redraw when message is same

fmasa · fmasa · commit 992aaab54d31 · 2019-10-07T15:45:47.000+02:00
diff --git a/src/Symfony/Component/Console/Helper/ProgressBar.php b/src/Symfony/Component/Console/Helper/ProgressBar.php
@@ -46,8 +46,7 @@ final class ProgressBar
     private $messages = [];
     private $overwrite = true;
     private $terminal;
-    private $firstRun = true;
-    private $currentMessage = '';
+    private $previousMessage;
 
     private static $formatters;
     private static $formats;
@@ -433,14 +432,14 @@ private function setRealFormat(string $format)
      */
     private function overwrite(string $message): void
     {
-        if ($this->currentMessage === $message) {
+        if ($this->previousMessage === $message) {
             return;
         }
 
-        $this->currentMessage = $message;
+        $originalMessage = $message;
 
         if ($this->overwrite) {
-            if (!$this->firstRun) {
+            if (null !== $this->previousMessage) {
                 if ($this->output instanceof ConsoleSectionOutput) {
                     $lines = floor(Helper::strlen($message) / $this->terminal->getWidth()) + $this->formatLineCount + 1;
                     $this->output->clear($lines);
@@ -458,7 +457,7 @@ private function overwrite(string $message): void
             $message = PHP_EOL.$message;
         }
 
-        $this->firstRun = false;
+        $this->previousMessage = $originalMessage;
         $this->lastWriteTime = microtime(true);
 
         $this->output->write($message);
