[Console] Fix fatal error when accessing Application::signalRegistry without pcntl

lyrixx · lyrixx · commit 9b30b94eb976 · 2023-02-24T14:14:21.000-05:00
diff --git a/src/Symfony/Component/Console/Application.php b/src/Symfony/Component/Console/Application.php
@@ -120,7 +120,7 @@ public function setCommandLoader(CommandLoaderInterface $commandLoader)
 
     public function getSignalRegistry(): SignalRegistry
     {
-        if (!$this->signalRegistry) {
+        if (!isset($this->signalRegistry)) {
             throw new RuntimeException('Signals are not supported. Make sure that the `pcntl` extension is installed and that "pcntl_*" functions are not disabled by your php.ini\'s "disable_functions" directive.');
         }
 
@@ -1004,7 +1004,7 @@ protected function doRunCommand(Command $command, InputInterface $input, OutputI
             $commandSignals = $command instanceof SignalableCommandInterface ? $command->getSubscribedSignals() : [];
 
             if ($commandSignals || null !== $this->dispatcher) {
-                if (!$this->signalRegistry) {
+                if (!isset($this->signalRegistry)) {
                     throw new RuntimeException('Unable to subscribe to signal events. Make sure that the `pcntl` extension is installed and that "pcntl_*" functions are not disabled by your php.ini\'s "disable_functions" directive.');
                 }
 

Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ public function setCommandLoader(CommandLoaderInterface $commandLoader)`
`120`	`120`
`121`	`121`	`public function getSignalRegistry(): SignalRegistry`
`122`	`122`	`{`
`123`		`- if (!$this->signalRegistry) {`
	`123`	`+ if (!isset($this->signalRegistry)) {`
`124`	`124`	throw new RuntimeException('Signals are not supported. Make sure that the `pcntl` extension is installed and that "pcntl_*" functions are not disabled by your php.ini\'s "disable_functions" directive.');
`125`	`125`	`}`
`126`	`126`
`@@ -1004,7 +1004,7 @@ protected function doRunCommand(Command $command, InputInterface $input, OutputI`
`1004`	`1004`	`$commandSignals = $command instanceof SignalableCommandInterface ? $command->getSubscribedSignals() : [];`
`1005`	`1005`
`1006`	`1006`	`if ($commandSignals \|\| null !== $this->dispatcher) {`
`1007`		`- if (!$this->signalRegistry) {`
	`1007`	`+ if (!isset($this->signalRegistry)) {`
`1008`	`1008`	throw new RuntimeException('Unable to subscribe to signal events. Make sure that the `pcntl` extension is installed and that "pcntl_*" functions are not disabled by your php.ini\'s "disable_functions" directive.');
`1009`	`1009`	`}`
`1010`	`1010`