feature #26791 [BrowserKit] Bypass Header Informations (cfjulien)

fabpot · fabpot · commit 9cb1f14ac39a · 2018-04-22T08:26:08.000+02:00
This PR was merged into the 4.1-dev branch. Discussion ---------- [BrowserKit] Bypass Header Informations This enables browser Testingtools like mink to pass headerfiles while doing a form submit | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR |  We tried to do some Browsertesting with Mink and Behat, something like: ```gherkin Scenario Outline: greet in native language Given the browser language is "<lang>" And I called the website When I fill in "PHP" for "username" And I submit the form Then I should see "<greeting>" Examples: | lang | greeting | | en | Hello | | de | Hallo | | fr | Bonjour | | zh | 你好 | | ru | привет | | be | Bonjour | ``` ```php public function theBrowserLanguageIs($arg1) { $this->getSession()->setRequestHeader('Accept', '*/*'); $this->getSession()->setRequestHeader('Accept-Language', $arg1); } ``` While everything works fine with visit form submit didn't send the headers. At Mink theres also an open issue for that minkphp/MinkBrowserKitDriver#79 but actually the problem was between the mink browserkit and the symfony client. Commits ------- fa2063e [BroserKit] Enable passthrew header information on submit
diff --git a/src/Symfony/Component/BrowserKit/Client.php b/src/Symfony/Component/BrowserKit/Client.php
@@ -289,11 +289,11 @@ public function click(Link $link)
      *
      * @return Crawler
      */
-    public function submit(Form $form, array $values = array())
+    public function submit(Form $form, array $values = array(), $serverParameters = array())
     {
         $form->setValues($values);
 
-        return $this->request($form->getMethod(), $form->getUri(), $form->getPhpValues(), $form->getPhpFiles());
+        return $this->request($form->getMethod(), $form->getUri(), $form->getPhpValues(), $form->getPhpFiles(), $serverParameters);
     }
 
     /**
diff --git a/src/Symfony/Component/BrowserKit/Tests/ClientTest.php b/src/Symfony/Component/BrowserKit/Tests/ClientTest.php
@@ -367,6 +367,20 @@ public function testSubmitPreserveAuth()
         $this->assertEquals('bar', $server['PHP_AUTH_PW']);
     }
 
+    public function testSubmitPassthrewHeaders()
+    {
+        $client = new TestClient();
+        $client->setNextResponse(new Response('<html><form action="/foo"><input type="submit" /></form></html>'));
+        $crawler = $client->request('GET', 'http://www.example.com/foo/foobar');
+        $headers = array('Accept-Language' => 'de');
+
+        $client->submit($crawler->filter('input')->form(), array(), $headers);
+
+        $server = $client->getRequest()->getServer();
+        $this->assertArrayHasKey('Accept-Language', $server);
+        $this->assertEquals('de', $server['Accept-Language']);
+    }
+
     public function testFollowRedirect()
     {
         $client = new TestClient();

Original file line number	Diff line number	Diff line change
`@@ -289,11 +289,11 @@ public function click(Link $link)`
`289`	`289`	`*`
`290`	`290`	`* @return Crawler`
`291`	`291`	`*/`
`292`		`- public function submit(Form $form, array $values = array())`
	`292`	`+ public function submit(Form $form, array $values = array(), $serverParameters = array())`
`293`	`293`	`{`
`294`	`294`	`$form->setValues($values);`
`295`	`295`
`296`		`- return $this->request($form->getMethod(), $form->getUri(), $form->getPhpValues(), $form->getPhpFiles());`
	`296`	`+ return $this->request($form->getMethod(), $form->getUri(), $form->getPhpValues(), $form->getPhpFiles(), $serverParameters);`
`297`	`297`	`}`
`298`	`298`
`299`	`299`	`/**`