feature #20777 [ClassLoader] Deprecate Apc/WinCache/Xcache class loaders (nicolas-grekas)

fabpot · fabpot · commit 9f475f8fed6d · 2016-12-06T14:31:11.000+01:00
This PR was merged into the 3.3-dev branch. Discussion ---------- [ClassLoader] Deprecate Apc/WinCache/Xcache class loaders | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | no | Fixed tickets | - | License | MIT | Doc PR | - See composer/composer#5559 Commits ------- fa36e1d [ClassLoader] Deprecate Apc/WinCache/Xcache class loaders
diff --git a/UPGRADE-3.3.md b/UPGRADE-3.3.md
@@ -0,0 +1,8 @@
+UPGRADE FROM 3.2 to 3.3
+=======================
+
+ClassLoader
+-----------
+
+ * The ApcClassLoader, WinCacheClassLoader and XcacheClassLoader classes have been deprecated
+   in favor of the `--apcu-autoloader` option introduced in composer 1.3
diff --git a/UPGRADE-4.0.md b/UPGRADE-4.0.md
@@ -1,6 +1,12 @@
 UPGRADE FROM 3.x to 4.0
 =======================
 
+ClassLoader
+-----------
+
+ * The ApcClassLoader, WinCacheClassLoader and XcacheClassLoader classes have been removed
+   in favor of the `--apcu-autoloader` option introduced in composer 1.3
+
 Console
 -------
 
diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/services.xml b/src/Symfony/Bundle/FrameworkBundle/Resources/config/services.xml
@@ -32,7 +32,6 @@
                 <argument>Symfony\Component\HttpFoundation\Request</argument>
                 <argument>Symfony\Component\HttpKernel\Kernel</argument>
                 <argument>Symfony\Component\ClassLoader\ClassCollectionLoader</argument>
-                <argument>Symfony\Component\ClassLoader\ApcClassLoader</argument>
             </argument>
         </service>
 
diff --git a/src/Symfony/Component/ClassLoader/ApcClassLoader.php b/src/Symfony/Component/ClassLoader/ApcClassLoader.php
@@ -11,6 +11,8 @@
 
 namespace Symfony\Component\ClassLoader;
 
+@trigger_error('The '.__NAMESPACE__.'\ApcClassLoader class is deprecated since version 3.3 and will be removed in 4.0. Use `composer install --apcu-autoloader` instead.', E_USER_DEPRECATED);
+
 /**
  * ApcClassLoader implements a wrapping autoloader cached in APC for PHP 5.3.
  *
@@ -44,6 +46,8 @@
  *
  * @author Fabien Potencier <fabien@symfony.com>
  * @author Kris Wallsmith <kris@symfony.com>
+ *
+ * @deprecated since version 3.3, to be removed in 4.0. Use `composer install --apcu-autoloader` instead.
  */
 class ApcClassLoader
 {
diff --git a/src/Symfony/Component/ClassLoader/CHANGELOG.md b/src/Symfony/Component/ClassLoader/CHANGELOG.md
@@ -1,6 +1,12 @@
 CHANGELOG
 =========
 
+3.3.0
+-----
+
+ * The ApcClassLoader, WinCacheClassLoader and XcacheClassLoader classes have been deprecated
+   in favor of the `--apcu-autoloader` option introduced in composer 1.3
+
 3.0.0
 -----
 
diff --git a/src/Symfony/Component/ClassLoader/Tests/ApcClassLoaderTest.php b/src/Symfony/Component/ClassLoader/Tests/ApcClassLoaderTest.php
@@ -14,6 +14,9 @@
 use Symfony\Component\ClassLoader\ApcClassLoader;
 use Symfony\Component\ClassLoader\ClassLoader;
 
+/**
+ * @group legacy
+ */
 class ApcClassLoaderTest extends \PHPUnit_Framework_TestCase
 {
     protected function setUp()
diff --git a/src/Symfony/Component/ClassLoader/WinCacheClassLoader.php b/src/Symfony/Component/ClassLoader/WinCacheClassLoader.php
@@ -11,6 +11,8 @@
 
 namespace Symfony\Component\ClassLoader;
 
+@trigger_error('The '.__NAMESPACE__.'\WinCacheClassLoader class is deprecated since version 3.3 and will be removed in 4.0. Use `composer install --apcu-autoloader` instead.', E_USER_DEPRECATED);
+
 /**
  * WinCacheClassLoader implements a wrapping autoloader cached in WinCache.
  *
@@ -43,6 +45,8 @@
  * @author Fabien Potencier <fabien@symfony.com>
  * @author Kris Wallsmith <kris@symfony.com>
  * @author Artem Ryzhkov <artem@smart-core.org>
+ *
+ * @deprecated since version 3.3, to be removed in 4.0. Use `composer install --apcu-autoloader` instead.
  */
 class WinCacheClassLoader
 {
diff --git a/src/Symfony/Component/ClassLoader/XcacheClassLoader.php b/src/Symfony/Component/ClassLoader/XcacheClassLoader.php
@@ -11,6 +11,8 @@
 
 namespace Symfony\Component\ClassLoader;
 
+@trigger_error('The '.__NAMESPACE__.'\XcacheClassLoader class is deprecated since version 3.3 and will be removed in 4.0. Use `composer install --apcu-autoloader` instead.', E_USER_DEPRECATED);
+
 /**
  * XcacheClassLoader implements a wrapping autoloader cached in XCache for PHP 5.3.
  *
@@ -43,6 +45,8 @@
  * @author Fabien Potencier <fabien@symfony.com>
  * @author Kris Wallsmith <kris@symfony.com>
  * @author Kim Hemsø Rasmussen <kimhemsoe@gmail.com>
+ *
+ * @deprecated since version 3.3, to be removed in 4.0. Use `composer install --apcu-autoloader` instead.
  */
 class XcacheClassLoader
 {

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,8 @@`
`11`	`11`
`12`	`12`	`namespace Symfony\Component\ClassLoader;`
`13`	`13`
	`14`	+@trigger_error('The '.__NAMESPACE__.'\ApcClassLoader class is deprecated since version 3.3 and will be removed in 4.0. Use `composer install --apcu-autoloader` instead.', E_USER_DEPRECATED);
	`15`	`+`
`14`	`16`	`/**`
`15`	`17`	`* ApcClassLoader implements a wrapping autoloader cached in APC for PHP 5.3.`
`16`	`18`	`*`
`@@ -44,6 +46,8 @@`
`44`	`46`	`*`
`45`	`47`	`* @author Fabien Potencier <[email protected]>`
`46`	`48`	`* @author Kris Wallsmith <[email protected]>`
	`49`	`+ *`
	`50`	+ * @deprecated since version 3.3, to be removed in 4.0. Use `composer install --apcu-autoloader` instead.
`47`	`51`	`*/`
`48`	`52`	`class ApcClassLoader`
`49`	`53`	`{`
Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,9 @@`
`14`	`14`	`use Symfony\Component\ClassLoader\ApcClassLoader;`
`15`	`15`	`use Symfony\Component\ClassLoader\ClassLoader;`
`16`	`16`
	`17`	`+/**`
	`18`	`+ * @group legacy`
	`19`	`+ */`
`17`	`20`	`class ApcClassLoaderTest extends \PHPUnit_Framework_TestCase`
`18`	`21`	`{`
`19`	`22`	`protected function setUp()`