[Form] Fixed: "required" attribute is not added to <select> tag if no empty value

webmozart · webmozart · commit a273e798985f · 2013-09-13T16:56:26.000+02:00
diff --git a/src/Symfony/Bridge/Twig/Resources/views/Form/form_div_layout.html.twig b/src/Symfony/Bridge/Twig/Resources/views/Form/form_div_layout.html.twig
@@ -67,6 +67,9 @@
 
 {% block choice_widget_collapsed %}
 {% spaceless %}
+    {% if required and empty_value is none and not empty_value_in_choices %}
+        {% set required = false %}
+    {% endif %}
     <select {{ block('widget_attributes') }}{% if multiple %} multiple="multiple"{% endif %}>
         {% if empty_value is not none %}
             <option value=""{% if required and value is empty %} selected="selected"{% endif %}>{{ empty_value|trans({}, translation_domain) }}</option>
diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/views/Form/choice_widget_collapsed.html.php b/src/Symfony/Bundle/FrameworkBundle/Resources/views/Form/choice_widget_collapsed.html.php
@@ -1,5 +1,7 @@
 <select
-    <?php echo $view['form']->block($form, 'widget_attributes') ?>
+    <?php echo $view['form']->block($form, 'widget_attributes', array(
+        'required' => $required && (null !== $empty_value || $empty_value_in_choices)
+    )) ?>
     <?php if ($multiple): ?> multiple="multiple"<?php endif ?>
 >
     <?php if (null !== $empty_value): ?><option value=""<?php if ($required and empty($value) && "0" !== $value): ?> selected="selected"<?php endif?>><?php echo $view->escape($view['translator']->trans($empty_value, array(), $translation_domain)) ?></option><?php endif; ?>
diff --git a/src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php b/src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php
@@ -119,8 +119,10 @@ public function buildView(FormView $view, FormInterface $form, array $options)
         }
 
         // Check if the choices already contain the empty value
+        $view->vars['empty_value_in_choices'] = 0 !== count($options['choice_list']->getChoicesForValues(array('')));
+
         // Only add the empty value option if this is not the case
-        if (null !== $options['empty_value'] && 0 === count($options['choice_list']->getChoicesForValues(array('')))) {
+        if (null !== $options['empty_value'] && !$view->vars['empty_value_in_choices']) {
             $view->vars['empty_value'] = $options['empty_value'];
         }
 
diff --git a/src/Symfony/Component/Form/Tests/AbstractLayoutTest.php b/src/Symfony/Component/Form/Tests/AbstractLayoutTest.php
@@ -369,10 +369,22 @@ public function testSingleChoice()
             'expanded' => false,
         ));
 
+        // If the field is collapsed, has no "multiple" attribute, is required but
+        // has *no* empty value, the "required" must not be added, otherwise
+        // the resulting HTML is invalid.
+        // https://github.com/symfony/symfony/issues/8942
+
+        // HTML 5 spec
+        // http://www.w3.org/html/wg/drafts/html/master/forms.html#placeholder-label-option
+
+        // "If a select element has a required attribute specified, does not
+        //  have a multiple attribute specified, and has a display size of 1,
+        //  then the select element must have a placeholder label option."
+
         $this->assertWidgetMatchesXpath($form->createView(), array(),
 '/select
     [@name="name"]
-    [@required="required"]
+    [not(@required)]
     [
         ./option[@value="&a"][@selected="selected"][.="[trans]Choice&A[/trans]"]
         /following-sibling::option[@value="&b"][not(@selected)][.="[trans]Choice&B[/trans]"]
@@ -394,7 +406,7 @@ public function testSingleChoiceWithPreferred()
         $this->assertWidgetMatchesXpath($form->createView(), array('separator' => '-- sep --'),
 '/select
     [@name="name"]
-    [@required="required"]
+    [not(@required)]
     [
         ./option[@value="&b"][not(@selected)][.="[trans]Choice&B[/trans]"]
         /following-sibling::option[@disabled="disabled"][not(@selected)][.="-- sep --"]
@@ -417,7 +429,7 @@ public function testSingleChoiceWithPreferredAndNoSeparator()
         $this->assertWidgetMatchesXpath($form->createView(), array('separator' => null),
 '/select
     [@name="name"]
-    [@required="required"]
+    [not(@required)]
     [
         ./option[@value="&b"][not(@selected)][.="[trans]Choice&B[/trans]"]
         /following-sibling::option[@value="&a"][@selected="selected"][.="[trans]Choice&A[/trans]"]
@@ -439,7 +451,7 @@ public function testSingleChoiceWithPreferredAndBlankSeparator()
         $this->assertWidgetMatchesXpath($form->createView(), array('separator' => ''),
 '/select
     [@name="name"]
-    [@required="required"]
+    [not(@required)]
     [
         ./option[@value="&b"][not(@selected)][.="[trans]Choice&B[/trans]"]
         /following-sibling::option[@disabled="disabled"][not(@selected)][.=""]
@@ -1704,7 +1716,7 @@ public function testTimezone()
         $this->assertWidgetMatchesXpath($form->createView(), array(),
 '/select
     [@name="name"]
-    [@required="required"]
+    [not(@required)]
     [./optgroup
         [@label="[trans]Europe[/trans]"]
         [./option[@value="Europe/Vienna"][@selected="selected"][.="[trans]Vienna[/trans]"]]
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/Type/ChoiceTypeTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/Type/ChoiceTypeTest.php
@@ -1050,6 +1050,7 @@ public function testPassEmptyValueToView($multiple, $expanded, $required, $empty
         $view = $form->createView();
 
         $this->assertEquals($viewValue, $view->vars['empty_value']);
+        $this->assertFalse($view->vars['empty_value_in_choices']);
     }
 
     /**
@@ -1067,6 +1068,7 @@ public function testDontPassEmptyValueIfContainedInChoices($multiple, $expanded,
         $view = $form->createView();
 
         $this->assertNull($view->vars['empty_value']);
+        $this->assertTrue($view->vars['empty_value_in_choices']);
     }
 
     public function getOptionsWithEmptyValue()

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,7 @@`
`1`	`1`	`<select`
`2`		`- <?php echo $view['form']->block($form, 'widget_attributes') ?>`
	`2`	`+ <?php echo $view['form']->block($form, 'widget_attributes', array(`
	`3`	`+ 'required' => $required && (null !== $empty_value \|\| $empty_value_in_choices)`
	`4`	`+ )) ?>`
`3`	`5`	`<?php if ($multiple): ?> multiple="multiple"<?php endif ?>`
`4`	`6`	`>`
`5`	`7`	`<?php if (null !== $empty_value): ?><option value=""<?php if ($required and empty($value) && "0" !== $value): ?> selected="selected"<?php endif?>><?php echo $view->escape($view['translator']->trans($empty_value, array(), $translation_domain)) ?></option><?php endif; ?>`
Original file line number	Diff line number	Diff line change
`@@ -119,8 +119,10 @@ public function buildView(FormView $view, FormInterface $form, array $options)`
`119`	`119`	`}`
`120`	`120`
`121`	`121`	`// Check if the choices already contain the empty value`
	`122`	`+ $view->vars['empty_value_in_choices'] = 0 !== count($options['choice_list']->getChoicesForValues(array('')));`
	`123`	`+`
`122`	`124`	`// Only add the empty value option if this is not the case`
`123`		`- if (null !== $options['empty_value'] && 0 === count($options['choice_list']->getChoicesForValues(array('')))) {`
	`125`	`+ if (null !== $options['empty_value'] && !$view->vars['empty_value_in_choices']) {`
`124`	`126`	`$view->vars['empty_value'] = $options['empty_value'];`
`125`	`127`	`}`
`126`	`128`
Original file line number	Diff line number	Diff line change
`@@ -1050,6 +1050,7 @@ public function testPassEmptyValueToView($multiple, $expanded, $required, $empty`
`1050`	`1050`	`$view = $form->createView();`
`1051`	`1051`
`1052`	`1052`	`$this->assertEquals($viewValue, $view->vars['empty_value']);`
	`1053`	`+ $this->assertFalse($view->vars['empty_value_in_choices']);`
`1053`	`1054`	`}`
`1054`	`1055`
`1055`	`1056`	`/**`
`@@ -1067,6 +1068,7 @@ public function testDontPassEmptyValueIfContainedInChoices($multiple, $expanded,`
`1067`	`1068`	`$view = $form->createView();`
`1068`	`1069`
`1069`	`1070`	`$this->assertNull($view->vars['empty_value']);`
	`1071`	`+ $this->assertTrue($view->vars['empty_value_in_choices']);`
`1070`	`1072`	`}`
`1071`	`1073`
`1072`	`1074`	`public function getOptionsWithEmptyValue()`