[Validator] Add hasViolations method to ConstraintViolationList

ostrolucky · ostrolucky · commit a375dfb1e599 · 2017-07-12T23:47:57.000+02:00
diff --git a/src/Symfony/Component/Validator/CHANGELOG.md b/src/Symfony/Component/Validator/CHANGELOG.md
@@ -7,6 +7,7 @@ CHANGELOG
  * not setting the `strict` option of the `Choice` constraint to `true` is
    deprecated and will throw an exception in Symfony 4.0
  * setting the `checkDNS` option of the `Url` constraint to `true` is deprecated in favor of constant values and will throw an exception in Symfony 4.0
+ * added `ConstraintViolationList::hasViolations()`
 
 3.3.0
 -----
diff --git a/src/Symfony/Component/Validator/ConstraintViolationList.php b/src/Symfony/Component/Validator/ConstraintViolationList.php
@@ -178,4 +178,14 @@ public function findByCodes($codes)
 
         return new static($violations);
     }
+
+    /**
+     * Returns whether this object contains violations.
+     *
+     * @return bool
+     */
+    public function hasViolations()
+    {
+        return (bool) $this->violations;
+    }
 }
diff --git a/src/Symfony/Component/Validator/Tests/ConstraintViolationListTest.php b/src/Symfony/Component/Validator/Tests/ConstraintViolationListTest.php
@@ -146,6 +146,17 @@ public function testFindByCodes($code, $violationsCount)
         $this->assertCount($violationsCount, $specificErrors);
     }
 
+    public function testHasViolations()
+    {
+        $list = new ConstraintViolationList();
+
+        $this->assertFalse($list->hasViolations());
+        $list->add($this->getViolation('Error'));
+        $this->assertTrue($list->hasViolations());
+        $list->remove(0);
+        $this->assertFalse($list->hasViolations());
+    }
+
     public function findByCodesProvider()
     {
         return array(

Original file line number	Diff line number	Diff line change
`@@ -178,4 +178,14 @@ public function findByCodes($codes)`
`178`	`178`
`179`	`179`	`return new static($violations);`
`180`	`180`	`}`
	`181`	`+`
	`182`	`+ /**`
	`183`	`+ * Returns whether this object contains violations.`
	`184`	`+ *`
	`185`	`+ * @return bool`
	`186`	`+ */`
	`187`	`+ public function hasViolations()`
	`188`	`+ {`
	`189`	`+ return (bool) $this->violations;`
	`190`	`+ }`
`181`	`191`	`}`