De-yoda conditionals

mtibben · mtibben · commit a527afe475ae · 2017-12-27T22:55:54.000+11:00
diff --git a/src/Symfony/Bundle/TwigBundle/DependencyInjection/Configuration.php b/src/Symfony/Bundle/TwigBundle/DependencyInjection/Configuration.php
@@ -210,7 +210,7 @@ private function addHttpExceptionLogLevels(ArrayNodeDefinition $rootNode)
                         ->always(function ($v) {
                             $map = array();
                             foreach ($v as $status => $level) {
-                                if (!(is_int($status) && 100 <= $status && $status <= 599)) {
+                                if (!(is_int($status) && $status >= 100 && $status <= 599)) {
                                     throw new InvalidConfigurationException(sprintf(
                                         'The configured status code "%s" in twig.http_exception_log_levels is not a valid http status code.',
                                          $status
diff --git a/src/Symfony/Component/HttpKernel/EventListener/ExceptionListener.php b/src/Symfony/Component/HttpKernel/EventListener/ExceptionListener.php
@@ -92,7 +92,7 @@ protected function getExceptionLogLevel(\Exception $exception): string
             $statusCode = $exception->getStatusCode();
             if (isset($this->httpStatusCodeLogLevel[$statusCode])) {
                 $logLevel = $this->httpStatusCodeLogLevel[$statusCode];
-            } elseif (400 <= $statusCode && $statusCode < 500) {
+            } elseif ($statusCode >= 400 && $statusCode < 500) {
                 $logLevel = LogLevel::WARNING;
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ protected function getExceptionLogLevel(\Exception $exception): string`
`92`	`92`	`$statusCode = $exception->getStatusCode();`
`93`	`93`	`if (isset($this->httpStatusCodeLogLevel[$statusCode])) {`
`94`	`94`	`$logLevel = $this->httpStatusCodeLogLevel[$statusCode];`
`95`		`- } elseif (400 <= $statusCode && $statusCode < 500) {`
	`95`	`+ } elseif ($statusCode >= 400 && $statusCode < 500) {`
`96`	`96`	`$logLevel = LogLevel::WARNING;`
`97`	`97`	`}`
`98`	`98`	`}`