minor #38567 [Cache] Make Redis initializers static (Nyholm)

fabpot · fabpot · commit a590e90698f3 · 2020-10-14T16:09:22.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [Cache] Make Redis initializers static | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes .. or maybe? | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | I am on very thin ice now. I saw a comment on similar code here: #38563 (comment) These anonymous functions in the cache component could also be made static to avoid being connected to the object using the Redis trait. Feel free to correct me if this does not make much sense. Commits ------- ad8de57 [Cache] Make Redis initializers static
diff --git a/src/Symfony/Component/Cache/Traits/RedisTrait.php b/src/Symfony/Component/Cache/Traits/RedisTrait.php
@@ -174,7 +174,7 @@ public static function createConnection($dsn, array $options = [])
             $connect = $params['persistent'] || $params['persistent_id'] ? 'pconnect' : 'connect';
             $redis = new $class();
 
-            $initializer = function ($redis) use ($connect, $params, $dsn, $auth, $hosts) {
+            $initializer = static function ($redis) use ($connect, $params, $dsn, $auth, $hosts) {
                 try {
                     @$redis->{$connect}($hosts[0]['host'] ?? $hosts[0]['path'], $hosts[0]['port'] ?? null, $params['timeout'], (string) $params['persistent_id'], $params['retry_interval']);
 
@@ -226,7 +226,7 @@ public static function createConnection($dsn, array $options = [])
                 $redis->setOption(\Redis::OPT_TCP_KEEPALIVE, $params['tcp_keepalive']);
             }
         } elseif (is_a($class, \RedisCluster::class, true)) {
-            $initializer = function () use ($class, $params, $dsn, $hosts) {
+            $initializer = static function () use ($class, $params, $dsn, $hosts) {
                 foreach ($hosts as $i => $host) {
                     $hosts[$i] = 'tcp' === $host['scheme'] ? $host['host'].':'.$host['port'] : $host['path'];
                 }
