Review

yceruto · yceruto · commit a600fbe79531 · 2019-03-07T07:36:54.000-05:00
diff --git a/src/Symfony/Component/OptionsResolver/CHANGELOG.md b/src/Symfony/Component/OptionsResolver/CHANGELOG.md
@@ -4,7 +4,7 @@ CHANGELOG
 4.3.0
 -----
 
- * added `addNormalizer` method
+ * added `OptionsResolver::addNormalizer` method
 
 4.2.0
 -----
diff --git a/src/Symfony/Component/OptionsResolver/Debug/OptionsResolverIntrospector.php b/src/Symfony/Component/OptionsResolver/Debug/OptionsResolverIntrospector.php
@@ -89,7 +89,7 @@ public function getNormalizer(string $option): \Closure
     }
 
     /**
-     * @throws NoConfigurationException on no configured normalizer
+     * @throws NoConfigurationException when no normalizer is configured
      */
     public function getNormalizers(string $option): array
     {
diff --git a/src/Symfony/Component/OptionsResolver/OptionsResolver.php b/src/Symfony/Component/OptionsResolver/OptionsResolver.php
@@ -497,7 +497,7 @@ public function setNormalizer($option, \Closure $normalizer)
      *
      * The normalizer should be a closure with the following signature:
      *
-     *     function (Options $options, $value) {
+     *     function (Options $options, $value): mixed {
      *         // ...
      *     }
      *

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ public function getNormalizer(string $option): \Closure`
`89`	`89`	`}`
`90`	`90`
`91`	`91`	`/**`
`92`		`- * @throws NoConfigurationException on no configured normalizer`
	`92`	`+ * @throws NoConfigurationException when no normalizer is configured`
`93`	`93`	`*/`
`94`	`94`	`public function getNormalizers(string $option): array`
`95`	`95`	`{`
Original file line number	Diff line number	Diff line change
`@@ -497,7 +497,7 @@ public function setNormalizer($option, \Closure $normalizer)`
`497`	`497`	`*`
`498`	`498`	`* The normalizer should be a closure with the following signature:`
`499`	`499`	`*`
`500`		`- * function (Options $options, $value) {`
	`500`	`+ * function (Options $options, $value): mixed {`
`501`	`501`	`* // ...`
`502`	`502`	`* }`
`503`	`503`	`*`