bug #19128 Avoid phpunit 5.4 warnings on getMock (2.7+) (iltar)

nicolas-grekas · nicolas-grekas · commit a65fe45ec99b · 2016-06-21T15:39:41.000+02:00
This PR was merged into the 2.7 branch. Discussion ---------- Avoid phpunit 5.4 warnings on getMock (2.7+) | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19125 | License | MIT | Doc PR | ~ Avoids calling `getMock()` in phpunit 5.4 which will trigger a warning (and thus failing test suite) when used by developers as this TestCase is an extension point. Commits ------- b05014c Avoid phpunit 5.4 warnings on getMock
diff --git a/src/Symfony/Component/Form/Test/TypeTestCase.php b/src/Symfony/Component/Form/Test/TypeTestCase.php
@@ -30,7 +30,7 @@ protected function setUp()
     {
         parent::setUp();
 
-        $this->dispatcher = $this->getMock('Symfony\Component\EventDispatcher\EventDispatcherInterface');
+        $this->dispatcher = $this->getMockBuilder('Symfony\Component\EventDispatcher\EventDispatcherInterface')->getMock();
         $this->builder = new FormBuilder(null, null, $this->dispatcher, $this->factory);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ protected function setUp()`
`30`	`30`	`{`
`31`	`31`	`parent::setUp();`
`32`	`32`
`33`		`- $this->dispatcher = $this->getMock('Symfony\Component\EventDispatcher\EventDispatcherInterface');`
	`33`	`+ $this->dispatcher = $this->getMockBuilder('Symfony\Component\EventDispatcher\EventDispatcherInterface')->getMock();`
`34`	`34`	`$this->builder = new FormBuilder(null, null, $this->dispatcher, $this->factory);`
`35`	`35`	`}`
`36`	`36`