Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit a7049f7

Browse files
fabpotfabpot
committed
bug #41451 [Translation] Remove PoEditor Provider (welcoMattic)
This PR was merged into the 5.3 branch. Discussion ---------- [Translation] Remove PoEditor Provider | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #41374 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | As it has been discussed in #41374, we have to remove the support of PoEditor as Translation Provider. The `translation:pull` command do not work as expected with PoEditor, translations keys are not retrieved as they do. I contacted PoEditor support in order to fix the bug (it miss the `resname` attribute of `trans-unit` tag in their XLIFF 1.2 export files). I will follow up their change in the next coming weeks/months, and I hope we could re-add the PoEditor Provider in Symfony for 5.4/6.0. Commits ------- b2ea42e Remove PoEditor Provider
2 parents 6c84cc8 + b2ea42e commit a7049f7

16 files changed

+1
-1018
lines changed

‎src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,6 @@
172172
use Symfony\Component\Translation\Bridge\Crowdin\CrowdinProviderFactory;
173173
use Symfony\Component\Translation\Bridge\Loco\LocoProviderFactory;
174174
use Symfony\Component\Translation\Bridge\Lokalise\LokaliseProviderFactory;
175-
use Symfony\Component\Translation\Bridge\PoEditor\PoEditorProviderFactory;
176175
use Symfony\Component\Translation\Command\XliffLintCommand as BaseXliffLintCommand;
177176
use Symfony\Component\Translation\PseudoLocalizationTranslator;
178177
use Symfony\Component\Translation\Translator;
@@ -1345,15 +1344,12 @@ private function registerTranslatorConfiguration(array $config, ContainerBuilder
13451344
CrowdinProviderFactory::class => 'translation.provider_factory.crowdin',
13461345
LocoProviderFactory::class => 'translation.provider_factory.loco',
13471346
LokaliseProviderFactory::class => 'translation.provider_factory.lokalise',
1348-
PoEditorProviderFactory::class => 'translation.provider_factory.poeditor',
13491347
];
13501348

13511349
$parentPackages = ['symfony/framework-bundle', 'symfony/translation', 'symfony/http-client'];
13521350

13531351
foreach ($classToServices as $class => $service) {
1354-
switch ($package = substr($service, \strlen('translation.provider_factory.'))) {
1355-
case 'poeditor': $package = 'po-editor'; break;
1356-
}
1352+
$package = substr($service, \strlen('translation.provider_factory.'));
13571353

13581354
if (!$container->hasDefinition('http_client') || !ContainerBuilder::willBeAvailable(sprintf('symfony/%s-translation-provider', $package), $class, $parentPackages)) {
13591355
$container->removeDefinition($service);

‎src/Symfony/Bundle/FrameworkBundle/Resources/config/translation_providers.php

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
use Symfony\Component\Translation\Bridge\Crowdin\CrowdinProviderFactory;
1515
use Symfony\Component\Translation\Bridge\Loco\LocoProviderFactory;
1616
use Symfony\Component\Translation\Bridge\Lokalise\LokaliseProviderFactory;
17-
use Symfony\Component\Translation\Bridge\PoEditor\PoEditorProviderFactory;
1817
use Symfony\Component\Translation\Provider\NullProviderFactory;
1918
use Symfony\Component\Translation\Provider\TranslationProviderCollection;
2019
use Symfony\Component\Translation\Provider\TranslationProviderCollectionFactory;
@@ -63,14 +62,5 @@
6362
service('translation.loader.xliff'),
6463
])
6564
->tag('translation.provider_factory')
66-
67-
->set('translation.provider_factory.poeditor', PoEditorProviderFactory::class)
68-
->args([
69-
service('http_client'),
70-
service('logger'),
71-
param('kernel.default_locale'),
72-
service('translation.loader.xliff'),
73-
])
74-
->tag('translation.provider_factory')
7565
;
7666
};

‎src/Symfony/Component/Translation/Bridge/PoEditor/.gitattributes

Lines changed: 0 additions & 4 deletions
This file was deleted.

‎src/Symfony/Component/Translation/Bridge/PoEditor/.gitignore

Lines changed: 0 additions & 3 deletions
This file was deleted.

‎src/Symfony/Component/Translation/Bridge/PoEditor/CHANGELOG.md

Lines changed: 0 additions & 7 deletions
This file was deleted.

‎src/Symfony/Component/Translation/Bridge/PoEditor/LICENSE

Lines changed: 0 additions & 19 deletions
This file was deleted.

‎src/Symfony/Component/Translation/Bridge/PoEditor/PoEditorHttpClient.php

Lines changed: 0 additions & 44 deletions
This file was deleted.

‎src/Symfony/Component/Translation/Bridge/PoEditor/PoEditorProvider.php

Lines changed: 0 additions & 214 deletions
This file was deleted.

0 commit comments

Comments
 (0)