[Form] Add support for \Traversable in 'choices' param of ChoiceType

kix · kix · commit a72a5fa0468e · 2015-06-17T23:16:46.000+05:00
diff --git a/src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php b/src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php
@@ -239,7 +239,7 @@ public function setDefaultOptions(OptionsResolverInterface $resolver)
         ));
 
         $resolver->setAllowedTypes(array(
-            'choices' => array('null', 'array'),
+            'choices' => array('null', 'array', 'Traversable'),
             'choice_list' => array('null', 'Symfony\Component\Form\Extension\Core\ChoiceList\ChoiceListInterface'),
             'preferred_choices' => 'array',
         ));
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/Type/ChoiceTypeTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/Type/ChoiceTypeTest.php
@@ -1672,6 +1672,13 @@ public function testInitializeWithDefaultObjectChoice()
         $form->getViewData();
     }
 
+    public function testChoicesOptionSupportsTraversable()
+    {
+        $this->factory->create('choice', null, array(
+            'choices' => new \ArrayObject($this->choices),
+        ));
+    }
+
     /**
      * @expectedException \Symfony\Component\OptionsResolver\Exception\InvalidOptionsException
      */
