Apply review changes

gnito-org · gnito-org · commit a73064d4750d · 2022-11-30T09:53:14.000-04:00
diff --git a/src/Symfony/Component/Notifier/Bridge/Bandwidth/Tests/BandwidthTransportFactoryTest.php b/src/Symfony/Component/Notifier/Bridge/Bandwidth/Tests/BandwidthTransportFactoryTest.php
@@ -22,7 +22,7 @@ public function createFactory(): BandwidthTransportFactory
 
     public function createProvider(): iterable
     {
-        yield ['bandwidth://host.test?from=0611223344&account_id=account_id&application_id=application_id&priority=priority', 'bandwidth://username:password@host.test?from=0611223344&account_id=account_id&application_id=application_id&priority=priority'];
+        yield ['bandwidth://host.test?from=0611223344&account_id=account_id&application_id=application_id&priority=priority', 'bandwidth://username:password@host.test?from=0611223344&account_id=account_id&application_id=application_id&priority=priority', 'bandwidth://username:password@host.test?from=0611223344&account_id=account_id&application_id=application_id'];
     }
 
     public function incompleteDsnProvider(): iterable
diff --git a/src/Symfony/Component/Notifier/Bridge/Bandwidth/Tests/BandwidthTransportTest.php b/src/Symfony/Component/Notifier/Bridge/Bandwidth/Tests/BandwidthTransportTest.php
@@ -29,7 +29,6 @@ public function createTransport(HttpClientInterface $client = null, string $from
 
     public function invalidFromProvider(): iterable
     {
-        // phone numbers
         yield 'no zero at start if phone number' => ['+0'];
         yield 'phone number too short' => ['+1'];
     }
diff --git a/src/Symfony/Component/Notifier/Bridge/Bandwidth/composer.json b/src/Symfony/Component/Notifier/Bridge/Bandwidth/composer.json
@@ -20,10 +20,12 @@
     ],
     "require": {
         "php": ">=8.1",
-        "symfony/event-dispatcher": "^5.4|^6.0",
         "symfony/http-client": "^5.4|^6.0",
         "symfony/notifier": "^6.3"
     },
+    "require-dev": {
+        "symfony/event-dispatcher": "^5.4|^6.0"
+    },
     "autoload": {
         "psr-4": {"Symfony\\Component\\Notifier\\Bridge\\Bandwidth\\": ""},
         "exclude-from-classmap": [

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ public function createFactory(): BandwidthTransportFactory`
`22`	`22`
`23`	`23`	`public function createProvider(): iterable`
`24`	`24`	`{`
`25`		`- yield ['bandwidth://host.test?from=0611223344&account_id=account_id&application_id=application_id&priority=priority', 'bandwidth://username:[email protected]?from=0611223344&account_id=account_id&application_id=application_id&priority=priority'];`
	`25`	`+ yield ['bandwidth://host.test?from=0611223344&account_id=account_id&application_id=application_id&priority=priority', 'bandwidth://username:[email protected]?from=0611223344&account_id=account_id&application_id=application_id&priority=priority', 'bandwidth://username:[email protected]?from=0611223344&account_id=account_id&application_id=application_id'];`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`public function incompleteDsnProvider(): iterable`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,6 @@ public function createTransport(HttpClientInterface $client = null, string $from`
`29`	`29`
`30`	`30`	`public function invalidFromProvider(): iterable`
`31`	`31`	`{`
`32`		`- // phone numbers`
`33`	`32`	`yield 'no zero at start if phone number' => ['+0'];`
`34`	`33`	`yield 'phone number too short' => ['+1'];`
`35`	`34`	`}`