[PasswordHasher] Fix wrong getSalt() check, method cannot return null

wouterj · wouterj · commit a7b370f8092d · 2021-08-17T14:11:53.000+02:00
diff --git a/src/Symfony/Component/PasswordHasher/Hasher/UserPasswordHasher.php b/src/Symfony/Component/PasswordHasher/Hasher/UserPasswordHasher.php
@@ -50,7 +50,7 @@ public function hashPassword($user, string $plainPassword): string
         } elseif ($user instanceof UserInterface) {
             $salt = $user->getSalt();
 
-            if (null !== $salt) {
+            if ($salt) {
                 trigger_deprecation('symfony/password-hasher', '5.3', 'Returning a string from "getSalt()" without implementing the "%s" interface is deprecated, the "%s" class should implement it.', LegacyPasswordAuthenticatedUserInterface::class, get_debug_type($user));
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ public function hashPassword($user, string $plainPassword): string`
`50`	`50`	`} elseif ($user instanceof UserInterface) {`
`51`	`51`	`$salt = $user->getSalt();`
`52`	`52`
`53`		`- if (null !== $salt) {`
	`53`	`+ if ($salt) {`
`54`	`54`	`trigger_deprecation('symfony/password-hasher', '5.3', 'Returning a string from "getSalt()" without implementing the "%s" interface is deprecated, the "%s" class should implement it.', LegacyPasswordAuthenticatedUserInterface::class, get_debug_type($user));`
`55`	`55`	`}`
`56`	`56`	`}`