bug #37770 [String] We cannot have a "provides" function in test cases (derrabus)

fabpot · fabpot · commit a8ea11b41974 · 2020-08-08T16:27:45.000+02:00
This PR was merged into the 5.1 branch. Discussion ---------- [String] We cannot have a "provides" function in test cases | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Part of #37564 | License | MIT | Doc PR | N/A Because of a change in PHPUnit 9.3 (see sebastianbergmann/phpunit#3936), we cannot have define a method named `provides` in test cases. And since php is case-insensitive regarding method calls, the method `provideS` used by the String component's `FunctionTest` will cause a fatal error. I have renamed it to work around that issue. cc @fancyweb Commits ------- 46e2a0c [String] We cannot have a "provides" function in test cases.
diff --git a/src/Symfony/Component/String/Tests/FunctionsTest.php b/src/Symfony/Component/String/Tests/FunctionsTest.php
@@ -20,14 +20,14 @@
 final class FunctionsTest extends TestCase
 {
     /**
-     * @dataProvider provideS
+     * @dataProvider provideStrings
      */
     public function testS(AbstractString $expected, string $input)
     {
         $this->assertEquals($expected, s($input));
     }
 
-    public function provideS()
+    public function provideStrings(): array
     {
         return [
             [new UnicodeString('foo'), 'foo'],

Original file line number	Diff line number	Diff line change
`@@ -20,14 +20,14 @@`
`20`	`20`	`final class FunctionsTest extends TestCase`
`21`	`21`	`{`
`22`	`22`	`/**`
`23`		`- * @dataProvider provideS`
	`23`	`+ * @dataProvider provideStrings`
`24`	`24`	`*/`
`25`	`25`	`public function testS(AbstractString $expected, string $input)`
`26`	`26`	`{`
`27`	`27`	`$this->assertEquals($expected, s($input));`
`28`	`28`	`}`
`29`	`29`
`30`		`- public function provideS()`
	`30`	`+ public function provideStrings(): array`
`31`	`31`	`{`
`32`	`32`	`return [`
`33`	`33`	`[new UnicodeString('foo'), 'foo'],`