bug #46668 [FrameworkBundle] Lower JsonSerializableNormalizer priority (aprat84)

nicolas-grekas · nicolas-grekas · commit aac6436f98cb · 2022-06-19T15:14:45.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] Lower JsonSerializableNormalizer priority | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | IMHO, more generic normalizers, like `ObjectNormalizer` or `JsonSerializableNormalizer` should have lower priority than other more specific normalizers, like `DateTimeNormalizer`, `ConstraintViolationListNormalizer`, etc. My issue was with `Carbon` library, which extends php's `DateTime`. `Carbon` classes implement `JsonSerializable` interface, so they are serialized with `JsonSerializableNormalizer`, using its internal `toJSON()` method, so I can't control which format I want them to be serialized. I should be able to do it, as I can with `DateTime`, cause both implement `DateTimeInterface`. That's because `JsonSerializableNormalizer` has higher priority than `DateTimeNormalizer`. For now, my "fix" was to change priority in config like so: ```yaml serializer.normalizer.json_serializable: class: Symfony\Component\Serializer\Normalizer\JsonSerializableNormalizer tags: - {name: 'serializer.normalizer', priority: -950 } ``` Commits ------- 3fcfc20 [FrameworkBundle] Lower JsonSerializableNormalizer priority
diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/serializer.xml b/src/Symfony/Bundle/FrameworkBundle/Resources/config/serializer.xml
@@ -60,7 +60,7 @@
 
         <service id="serializer.normalizer.json_serializable" class="Symfony\Component\Serializer\Normalizer\JsonSerializableNormalizer">
             <!-- Run before serializer.normalizer.object -->
-            <tag name="serializer.normalizer" priority="-900" />
+            <tag name="serializer.normalizer" priority="-950" />
         </service>
 
         <service id="serializer.normalizer.problem" class="Symfony\Component\Serializer\Normalizer\ProblemNormalizer">
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
@@ -1297,7 +1297,7 @@ public function testJsonSerializableNormalizerRegistered()
         $tag = $definition->getTag('serializer.normalizer');
 
         $this->assertEquals(JsonSerializableNormalizer::class, $definition->getClass());
-        $this->assertEquals(-900, $tag[0]['priority']);
+        $this->assertEquals(-950, $tag[0]['priority']);
     }
 
     public function testObjectNormalizerRegistered()

Original file line number	Diff line number	Diff line change
`@@ -1297,7 +1297,7 @@ public function testJsonSerializableNormalizerRegistered()`
`1297`	`1297`	`$tag = $definition->getTag('serializer.normalizer');`
`1298`	`1298`
`1299`	`1299`	`$this->assertEquals(JsonSerializableNormalizer::class, $definition->getClass());`
`1300`		`- $this->assertEquals(-900, $tag[0]['priority']);`
	`1300`	`+ $this->assertEquals(-950, $tag[0]['priority']);`
`1301`	`1301`	`}`
`1302`	`1302`
`1303`	`1303`	`public function testObjectNormalizerRegistered()`