minor #40470 [Cache] fix test case name (nicolas-grekas)

chalasr · chalasr · commit abf16d0f1b42 · 2021-03-15T19:43:41.000+01:00
This PR was merged into the 4.4 branch. Discussion ---------- [Cache] fix test case name | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Should make #40468 green. Commits ------- e2dffea [Translation] fix test case name
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
@@ -1723,7 +1723,7 @@ protected function createContainerFromFile($file, $data = [], $resetCompilerPass
             $container->getCompilerPassConfig()->setAfterRemovingPasses([]);
         }
         $container->getCompilerPassConfig()->setBeforeOptimizationPasses([new LoggerPass()]);
-        $container->getCompilerPassConfig()->setBeforeRemovingPasses([new AddConstraintValidatorsPass(), new TranslatorPass('translator.default', 'translation.reader')]);
+        $container->getCompilerPassConfig()->setBeforeRemovingPasses([new AddConstraintValidatorsPass(), new TranslatorPass()]);
         $container->getCompilerPassConfig()->setAfterRemovingPasses([new AddAnnotationsCachedReaderPass()]);
 
         if (!$compile) {
diff --git a/src/Symfony/Component/Translation/Tests/DependencyInjection/TranslatorPassTest.php b/src/Symfony/Component/Translation/Tests/DependencyInjection/TranslatorPassTest.php
@@ -18,7 +18,7 @@
 use Symfony\Component\DependencyInjection\Reference;
 use Symfony\Component\Translation\DependencyInjection\TranslatorPass;
 
-class TranslationPassTest extends TestCase
+class TranslatorPassTest extends TestCase
 {
     public function testValidCollector()
     {
@@ -35,7 +35,7 @@ public function testValidCollector()
         $container->setDefinition('translation.reader', $reader);
         $container->setDefinition('translation.xliff_loader', $loader);
 
-        $pass = new TranslatorPass('translator.default', 'translation.reader');
+        $pass = new TranslatorPass();
         $pass->process($container);
 
         $expectedReader = (new Definition())
@@ -72,7 +72,7 @@ public function testValidCommandsViewPathsArgument()
         ;
         $container->setParameter('twig.default_path', 'templates');
 
-        $pass = new TranslatorPass('translator.default');
+        $pass = new TranslatorPass();
         $pass->process($container);
 
         $expectedViewPaths = ['other/templates', 'tpl'];
@@ -113,7 +113,7 @@ public function testCommandsViewPathsArgumentsAreIgnoredWithOldServiceDefinition
         ;
         $container->setParameter('twig.default_path', 'templates');
 
-        $pass = new TranslatorPass('translator.default');
+        $pass = new TranslatorPass();
         $pass->process($container);
 
         $this->assertSame('templates', $debugCommand->getArgument(4));

Original file line number	Diff line number	Diff line change
`@@ -1723,7 +1723,7 @@ protected function createContainerFromFile($file, $data = [], $resetCompilerPass`
`1723`	`1723`	`$container->getCompilerPassConfig()->setAfterRemovingPasses([]);`
`1724`	`1724`	`}`
`1725`	`1725`	`$container->getCompilerPassConfig()->setBeforeOptimizationPasses([new LoggerPass()]);`
`1726`		`- $container->getCompilerPassConfig()->setBeforeRemovingPasses([new AddConstraintValidatorsPass(), new TranslatorPass('translator.default', 'translation.reader')]);`
	`1726`	`+ $container->getCompilerPassConfig()->setBeforeRemovingPasses([new AddConstraintValidatorsPass(), new TranslatorPass()]);`
`1727`	`1727`	`$container->getCompilerPassConfig()->setAfterRemovingPasses([new AddAnnotationsCachedReaderPass()]);`
`1728`	`1728`
`1729`	`1729`	`if (!$compile) {`