[Console] Fix deprecation when description is null

HypeMC · HypeMC · commit ae001150572f · 2022-06-07T04:10:23.000+02:00
str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated
diff --git a/src/Symfony/Component/Console/DependencyInjection/AddConsoleCommandPass.php b/src/Symfony/Component/Console/DependencyInjection/AddConsoleCommandPass.php
@@ -56,6 +56,7 @@ public function process(ContainerBuilder $container)
         foreach ($commandServices as $id => $tags) {
             $definition = $container->getDefinition($id);
             $definition->addTag($this->noPreloadTag);
+            /** @var class-string<Command> $class */
             $class = $container->getParameterBag()->resolveValue($definition->getClass());
 
             if (isset($tags[0]['command'])) {
@@ -124,7 +125,7 @@ public function process(ContainerBuilder $container)
                 if (!$r->isSubclassOf(Command::class)) {
                     throw new InvalidArgumentException(sprintf('The service "%s" tagged "%s" must be a subclass of "%s".', $id, $this->commandTag, Command::class));
                 }
-                $description = str_replace('%', '%%', $class::getDefaultDescription());
+                $description = str_replace('%', '%%', $class::getDefaultDescription() ?? '');
             }
 
             if ($description) {

Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,7 @@ public function process(ContainerBuilder $container)`
`56`	`56`	`foreach ($commandServices as $id => $tags) {`
`57`	`57`	`$definition = $container->getDefinition($id);`
`58`	`58`	`$definition->addTag($this->noPreloadTag);`
	`59`	`+ /** @var class-string<Command> $class */`
`59`	`60`	`$class = $container->getParameterBag()->resolveValue($definition->getClass());`
`60`	`61`
`61`	`62`	`if (isset($tags[0]['command'])) {`
`@@ -124,7 +125,7 @@ public function process(ContainerBuilder $container)`
`124`	`125`	`if (!$r->isSubclassOf(Command::class)) {`
`125`	`126`	`throw new InvalidArgumentException(sprintf('The service "%s" tagged "%s" must be a subclass of "%s".', $id, $this->commandTag, Command::class));`
`126`	`127`	`}`
`127`		`- $description = str_replace('%', '%%', $class::getDefaultDescription());`
	`128`	`+ $description = str_replace('%', '%%', $class::getDefaultDescription() ?? '');`
`128`	`129`	`}`
`129`	`130`
`130`	`131`	`if ($description) {`