Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit aeb6822

Browse files
webmozartwebmozart
committed
[Validator] Improved visitor names
1 parent 08172bf commit aeb6822

File tree

8 files changed

+24
-26
lines changed

8 files changed

+24
-26
lines changed

‎src/Symfony/Component/Validator/NodeTraverser/NodeTraverser.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,9 @@
1212
namespace Symfony\Component\Validator\NodeTraverser;
1313

1414
use Symfony\Component\Validator\Context\ExecutionContextInterface;
15-
use Symfony\Component\Validator\Exception\ConstraintDefinitionException;
1615
use Symfony\Component\Validator\Exception\NoSuchMetadataException;
1716
use Symfony\Component\Validator\Mapping\CascadingStrategy;
1817
use Symfony\Component\Validator\Mapping\ClassMetadataInterface;
19-
use Symfony\Component\Validator\Mapping\CollectionMetadata;
2018
use Symfony\Component\Validator\Mapping\TraversalStrategy;
2119
use Symfony\Component\Validator\MetadataFactoryInterface;
2220
use Symfony\Component\Validator\Node\ClassNode;
@@ -132,7 +130,7 @@ private function traverseNode(Node $node, Traversal $traversal)
132130
return;
133131
}
134132

135-
// The "cascadedGroups" property is set by the NodeValidatorVisitor when
133+
// The "cascadedGroups" property is set by the NodeValidationVisitor when
136134
// traversing group sequences
137135
$cascadedGroups = null !== $node->cascadedGroups
138136
? $node->cascadedGroups

‎src/Symfony/Component/Validator/NodeVisitor/ContextRefresherVisitor.php renamed to ‎src/Symfony/Component/Validator/NodeVisitor/ContextUpdateVisitor.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,13 @@
2222
* @since 2.5
2323
* @author Bernhard Schussek <[email protected]>
2424
*/
25-
class ContextRefresherVisitor extends AbstractVisitor
25+
class ContextUpdateVisitor extends AbstractVisitor
2626
{
2727
public function visit(Node $node, ExecutionContextInterface $context)
2828
{
2929
if (!$context instanceof NodeObserverInterface) {
3030
throw new RuntimeException(sprintf(
31-
'The ContextRefresherVisitor only supports instances of class '.
31+
'The ContextUpdateVisitor only supports instances of class '.
3232
'"Symfony\Component\Validator\NodeVisitor\NodeObserverInterface". '.
3333
'An instance of class "%s" was given.',
3434
get_class($context)

‎src/Symfony/Component/Validator/NodeVisitor/GroupSequenceResolverVisitor.php renamed to ‎src/Symfony/Component/Validator/NodeVisitor/GroupSequenceResolvingVisitor.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
* @since %%NextVersion%%
2222
* @author Bernhard Schussek <[email protected]>
2323
*/
24-
class GroupSequenceResolverVisitor extends AbstractVisitor
24+
class GroupSequenceResolvingVisitor extends AbstractVisitor
2525
{
2626
public function visit(Node $node, ExecutionContextInterface $context)
2727
{

‎src/Symfony/Component/Validator/NodeVisitor/NodeValidatorVisitor.php renamed to ‎src/Symfony/Component/Validator/NodeVisitor/NodeValidationVisitor.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
* @since %%NextVersion%%
2626
* @author Bernhard Schussek <[email protected]>
2727
*/
28-
class NodeValidatorVisitor extends AbstractVisitor implements GroupManagerInterface
28+
class NodeValidationVisitor extends AbstractVisitor implements GroupManagerInterface
2929
{
3030
private $validatedObjects = array();
3131

‎src/Symfony/Component/Validator/NodeVisitor/ObjectInitializerVisitor.php renamed to ‎src/Symfony/Component/Validator/NodeVisitor/ObjectInitializationVisitor.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
* @since %%NextVersion%%
2121
* @author Bernhard Schussek <[email protected]>
2222
*/
23-
class ObjectInitializerVisitor extends AbstractVisitor
23+
class ObjectInitializationVisitor extends AbstractVisitor
2424
{
2525
/**
2626
* @var ObjectInitializerInterface[]

‎src/Symfony/Component/Validator/Tests/Validator/LegacyValidator2Dot5ApiTest.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@
1515
use Symfony\Component\Validator\ConstraintValidatorFactory;
1616
use Symfony\Component\Validator\Context\LegacyExecutionContextFactory;
1717
use Symfony\Component\Validator\MetadataFactoryInterface;
18-
use Symfony\Component\Validator\NodeVisitor\ContextRefresherVisitor;
19-
use Symfony\Component\Validator\NodeVisitor\GroupSequenceResolverVisitor;
20-
use Symfony\Component\Validator\NodeVisitor\NodeValidatorVisitor;
18+
use Symfony\Component\Validator\NodeVisitor\ContextUpdateVisitor;
19+
use Symfony\Component\Validator\NodeVisitor\GroupSequenceResolvingVisitor;
20+
use Symfony\Component\Validator\NodeVisitor\NodeValidationVisitor;
2121
use Symfony\Component\Validator\NodeTraverser\NodeTraverser;
2222
use Symfony\Component\Validator\Validator\LegacyValidator;
2323

@@ -26,11 +26,11 @@ class LegacyValidator2Dot5ApiTest extends Abstract2Dot5ApiTest
2626
protected function createValidator(MetadataFactoryInterface $metadataFactory)
2727
{
2828
$nodeTraverser = new NodeTraverser($metadataFactory);
29-
$nodeValidator = new NodeValidatorVisitor($nodeTraverser, new ConstraintValidatorFactory());
29+
$nodeValidator = new NodeValidationVisitor($nodeTraverser, new ConstraintValidatorFactory());
3030
$contextFactory = new LegacyExecutionContextFactory($nodeValidator, new DefaultTranslator());
3131
$validator = new LegacyValidator($contextFactory, $nodeTraverser, $metadataFactory);
32-
$groupSequenceResolver = new GroupSequenceResolverVisitor();
33-
$contextRefresher = new ContextRefresherVisitor();
32+
$groupSequenceResolver = new GroupSequenceResolvingVisitor();
33+
$contextRefresher = new ContextUpdateVisitor();
3434

3535
$nodeTraverser->addVisitor($groupSequenceResolver);
3636
$nodeTraverser->addVisitor($contextRefresher);

‎src/Symfony/Component/Validator/Tests/Validator/LegacyValidatorLegacyApiTest.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@
1515
use Symfony\Component\Validator\ConstraintValidatorFactory;
1616
use Symfony\Component\Validator\Context\LegacyExecutionContextFactory;
1717
use Symfony\Component\Validator\MetadataFactoryInterface;
18-
use Symfony\Component\Validator\NodeVisitor\ContextRefresherVisitor;
19-
use Symfony\Component\Validator\NodeVisitor\GroupSequenceResolverVisitor;
20-
use Symfony\Component\Validator\NodeVisitor\NodeValidatorVisitor;
18+
use Symfony\Component\Validator\NodeVisitor\ContextUpdateVisitor;
19+
use Symfony\Component\Validator\NodeVisitor\GroupSequenceResolvingVisitor;
20+
use Symfony\Component\Validator\NodeVisitor\NodeValidationVisitor;
2121
use Symfony\Component\Validator\NodeTraverser\NodeTraverser;
2222
use Symfony\Component\Validator\Validator\LegacyValidator;
2323

@@ -26,11 +26,11 @@ class LegacyValidatorLegacyApiTest extends AbstractLegacyApiTest
2626
protected function createValidator(MetadataFactoryInterface $metadataFactory)
2727
{
2828
$nodeTraverser = new NodeTraverser($metadataFactory);
29-
$nodeValidator = new NodeValidatorVisitor($nodeTraverser, new ConstraintValidatorFactory());
29+
$nodeValidator = new NodeValidationVisitor($nodeTraverser, new ConstraintValidatorFactory());
3030
$contextFactory = new LegacyExecutionContextFactory($nodeValidator, new DefaultTranslator());
3131
$validator = new LegacyValidator($contextFactory, $nodeTraverser, $metadataFactory);
32-
$groupSequenceResolver = new GroupSequenceResolverVisitor();
33-
$contextRefresher = new ContextRefresherVisitor();
32+
$groupSequenceResolver = new GroupSequenceResolvingVisitor();
33+
$contextRefresher = new ContextUpdateVisitor();
3434

3535
$nodeTraverser->addVisitor($groupSequenceResolver);
3636
$nodeTraverser->addVisitor($contextRefresher);

‎src/Symfony/Component/Validator/Tests/Validator/Validator2Dot5ApiTest.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@
1515
use Symfony\Component\Validator\ConstraintValidatorFactory;
1616
use Symfony\Component\Validator\Context\ExecutionContextFactory;
1717
use Symfony\Component\Validator\MetadataFactoryInterface;
18-
use Symfony\Component\Validator\NodeVisitor\ContextRefresherVisitor;
19-
use Symfony\Component\Validator\NodeVisitor\GroupSequenceResolverVisitor;
20-
use Symfony\Component\Validator\NodeVisitor\NodeValidatorVisitor;
18+
use Symfony\Component\Validator\NodeVisitor\ContextUpdateVisitor;
19+
use Symfony\Component\Validator\NodeVisitor\GroupSequenceResolvingVisitor;
20+
use Symfony\Component\Validator\NodeVisitor\NodeValidationVisitor;
2121
use Symfony\Component\Validator\NodeTraverser\NodeTraverser;
2222
use Symfony\Component\Validator\Validator\Validator;
2323

@@ -26,11 +26,11 @@ class Validator2Dot5ApiTest extends Abstract2Dot5ApiTest
2626
protected function createValidator(MetadataFactoryInterface $metadataFactory)
2727
{
2828
$nodeTraverser = new NodeTraverser($metadataFactory);
29-
$nodeValidator = new NodeValidatorVisitor($nodeTraverser, new ConstraintValidatorFactory());
29+
$nodeValidator = new NodeValidationVisitor($nodeTraverser, new ConstraintValidatorFactory());
3030
$contextFactory = new ExecutionContextFactory($nodeValidator, new DefaultTranslator());
3131
$validator = new Validator($contextFactory, $nodeTraverser, $metadataFactory);
32-
$groupSequenceResolver = new GroupSequenceResolverVisitor();
33-
$contextRefresher = new ContextRefresherVisitor();
32+
$groupSequenceResolver = new GroupSequenceResolvingVisitor();
33+
$contextRefresher = new ContextUpdateVisitor();
3434

3535
$nodeTraverser->addVisitor($groupSequenceResolver);
3636
$nodeTraverser->addVisitor($contextRefresher);

0 commit comments

Comments
 (0)