[Mailer] Fix error message in case of an STMP error

fabpot · fabpot · commit aee6d084b971 · 2022-08-01T19:58:20.000+02:00
diff --git a/src/Symfony/Component/Mailer/Transport/Smtp/EsmtpTransport.php b/src/Symfony/Component/Mailer/Transport/Smtp/EsmtpTransport.php
@@ -94,15 +94,7 @@ public function addAuthenticator(AuthenticatorInterface $authenticator): void
 
     protected function doHeloCommand(): void
     {
-        try {
-            $response = $this->executeCommand(sprintf("EHLO %s\r\n", $this->getLocalDomain()), [250]);
-        } catch (TransportExceptionInterface $e) {
-            parent::doHeloCommand();
-
-            return;
-        }
-
-        $capabilities = $this->getCapabilities($response);
+        $capabilities = $this->callHeloCommand();
 
         /** @var SocketStream $stream */
         $stream = $this->getStream();
@@ -116,25 +108,30 @@ protected function doHeloCommand(): void
                 throw new TransportException('Unable to connect with STARTTLS.');
             }
 
-            try {
-                $response = $this->executeCommand(sprintf("EHLO %s\r\n", $this->getLocalDomain()), [250]);
-                $capabilities = $this->getCapabilities($response);
-            } catch (TransportExceptionInterface $e) {
-                parent::doHeloCommand();
-
-                return;
-            }
+            $capabilities = $this->callHeloCommand();
         }
 
         if (\array_key_exists('AUTH', $capabilities)) {
             $this->handleAuth($capabilities['AUTH']);
         }
     }
 
-    private function getCapabilities(string $ehloResponse): array
+    private function callHeloCommand(): array
     {
+        try {
+            $response = $this->executeCommand(sprintf("EHLO %s\r\n", $this->getLocalDomain()), [250]);
+        } catch (TransportExceptionInterface $e) {
+            try {
+                parent::doHeloCommand();
+            } catch (TransportExceptionInterface $ex) {
+                if (!$ex->getCode()) {
+                    throw $e;
+                }
+            }
+        }
+
         $capabilities = [];
-        $lines = explode("\r\n", trim($ehloResponse));
+        $lines = explode("\r\n", trim($response));
         array_shift($lines);
         foreach ($lines as $line) {
             if (preg_match('/^[0-9]{3}[ -]([A-Z0-9-]+)((?:[ =].*)?)$/Di', $line, $matches)) {
diff --git a/src/Symfony/Component/Mailer/Transport/Smtp/SmtpTransport.php b/src/Symfony/Component/Mailer/Transport/Smtp/SmtpTransport.php
@@ -295,15 +295,13 @@ private function assertResponseCode(string $response, array $codes): void
             throw new LogicException('You must set the expected response code.');
         }
 
-        if (!$response) {
-            throw new TransportException(sprintf('Expected response code "%s" but got an empty response.', implode('/', $codes)));
-        }
-
         [$code] = sscanf($response, '%3d');
         $valid = \in_array($code, $codes);
 
-        if (!$valid) {
-            throw new TransportException(sprintf('Expected response code "%s" but got code "%s", with message "%s".', implode('/', $codes), $code, trim($response)), $code);
+        if (!$valid || !$response) {
+            $codeStr = $code ? sprintf('code "%s"', $code) : 'empty code';
+            $responseStr = $response ? sprintf(', with message "%s"', trim($response)) : '';
+            throw new TransportException(sprintf('Expected response code "%s" but got ', implode('/', $codes), $codeStr).$codeStr.$responseStr.'.', $code);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -295,15 +295,13 @@ private function assertResponseCode(string $response, array $codes): void`
`295`	`295`	`throw new LogicException('You must set the expected response code.');`
`296`	`296`	`}`
`297`	`297`
`298`		`- if (!$response) {`
`299`		`- throw new TransportException(sprintf('Expected response code "%s" but got an empty response.', implode('/', $codes)));`
`300`		`- }`
`301`		`-`
`302`	`298`	`[$code] = sscanf($response, '%3d');`
`303`	`299`	`$valid = \in_array($code, $codes);`
`304`	`300`
`305`		`- if (!$valid) {`
`306`		`- throw new TransportException(sprintf('Expected response code "%s" but got code "%s", with message "%s".', implode('/', $codes), $code, trim($response)), $code);`
	`301`	`+ if (!$valid \|\| !$response) {`
	`302`	`+ $codeStr = $code ? sprintf('code "%s"', $code) : 'empty code';`
	`303`	`+ $responseStr = $response ? sprintf(', with message "%s"', trim($response)) : '';`
	`304`	`+ throw new TransportException(sprintf('Expected response code "%s" but got ', implode('/', $codes), $codeStr).$codeStr.$responseStr.'.', $code);`
`307`	`305`	`}`
`308`	`306`	`}`
`309`	`307`