throw exception if calling Email::from() with no address

0x346e3730 · 0x346e3730 · commit aee9d51209b4 · 2024-01-19T09:23:07.000+04:00
diff --git a/src/Symfony/Component/Mime/Email.php b/src/Symfony/Component/Mime/Email.php
@@ -121,6 +121,10 @@ public function addFrom(...$addresses)
      */
     public function from(...$addresses)
     {
+        if (!$addresses) {
+            throw new LogicException(sprintf('"from()" must be called with at least one address.'));
+        }
+
         return $this->setListAddressHeaderBody('From', $addresses);
     }
 
diff --git a/src/Symfony/Component/Mime/Tests/EmailTest.php b/src/Symfony/Component/Mime/Tests/EmailTest.php
@@ -15,6 +15,7 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Mime\Address;
 use Symfony\Component\Mime\Email;
+use Symfony\Component\Mime\Exception\LogicException;
 use Symfony\Component\Mime\Part\DataPart;
 use Symfony\Component\Mime\Part\Multipart\AlternativePart;
 use Symfony\Component\Mime\Part\Multipart\MixedPart;
@@ -62,6 +63,13 @@ public function testSender()
         $this->assertSame($fabien, $e->getSender());
     }
 
+    public function testFromWithNoAddress()
+    {
+        $e = new Email();
+        $this->expectException(LogicException::class);
+        $e->from();
+    }
+
     public function testFrom()
     {
         $e = new Email();

Original file line number	Diff line number	Diff line change
`@@ -121,6 +121,10 @@ public function addFrom(...$addresses)`
`121`	`121`	`*/`
`122`	`122`	`public function from(...$addresses)`
`123`	`123`	`{`
	`124`	`+ if (!$addresses) {`
	`125`	`+ throw new LogicException(sprintf('"from()" must be called with at least one address.'));`
	`126`	`+ }`
	`127`	`+`
`124`	`128`	`return $this->setListAddressHeaderBody('From', $addresses);`
`125`	`129`	`}`
`126`	`130`