bug #16111 Throw exception if tempnam returns false in ProcessPipes (pierredup)

Tobion · Tobion · commit af2768c2d1e4 · 2015-10-04T17:49:48.000+02:00
This PR was merged into the 2.3 branch. Discussion ---------- Throw exception if tempnam returns false in ProcessPipes | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15215 | License | MIT | Doc PR | Related to #16092 Commits ------- 1425b8a Throw exception if tempnam returns false in ProcessPipes
diff --git a/src/Symfony/Component/Process/ProcessPipes.php b/src/Symfony/Component/Process/ProcessPipes.php
@@ -44,12 +44,11 @@ public function __construct($useFiles, $ttyMode)
         // @see https://bugs.php.net/bug.php?id=51800
         if ($this->useFiles) {
             $this->files = array(
-                Process::STDOUT => tempnam(sys_get_temp_dir(), 'sf_proc_stdout'),
-                Process::STDERR => tempnam(sys_get_temp_dir(), 'sf_proc_stderr'),
+                Process::STDOUT => tempnam(sys_get_temp_dir(), 'out_sf_proc'),
+                Process::STDERR => tempnam(sys_get_temp_dir(), 'err_sf_proc'),
             );
             foreach ($this->files as $offset => $file) {
-                $this->fileHandles[$offset] = fopen($this->files[$offset], 'rb');
-                if (false === $this->fileHandles[$offset]) {
+                if (false === $file || false === $this->fileHandles[$offset] = fopen($file, 'rb')) {
                     throw new RuntimeException('A temporary file could not be opened to write the process output to, verify that your TEMP environment variable is writable');
                 }
             }
