Document fields of the NativeClientState.

derrabus · derrabus · commit af3eeeeeab24 · 2019-04-07T14:20:39.000+02:00
diff --git a/src/Symfony/Component/HttpClient/ClientState/NativeClientState.php b/src/Symfony/Component/HttpClient/ClientState/NativeClientState.php
@@ -11,6 +11,8 @@
 
 namespace Symfony\Component\HttpClient\ClientState;
 
+use Symfony\Component\HttpClient\Response\NativeResponse;
+
 /**
  * Internal representation of the native client's state.
  *
@@ -20,12 +22,19 @@
  */
 final class NativeClientState extends AbstractClientState
 {
+    /** @var int */
     public $id;
+    /** @var NativeResponse[] */
     public $pendingResponses = [];
+    /** @var int */
     public $maxHostConnections = PHP_INT_MAX;
+    /** @var int */
     public $responseCount = 0;
+    /** @var string[] */
     public $dnsCache = [];
+    /** @var resource[] */
     public $handles = [];
+    /** @var bool */
     public $sleep = false;
 
     public function __construct()
diff --git a/src/Symfony/Component/HttpClient/Response/CurlResponse.php b/src/Symfony/Component/HttpClient/Response/CurlResponse.php
@@ -28,6 +28,8 @@ final class CurlResponse implements ResponseInterface
     use ResponseTrait;
 
     private static $performing = false;
+    /** @var CurlClientState */
+    private $multi;
 
     /**
      * @internal
diff --git a/src/Symfony/Component/HttpClient/Response/NativeResponse.php b/src/Symfony/Component/HttpClient/Response/NativeResponse.php
@@ -34,6 +34,8 @@ final class NativeResponse implements ResponseInterface
     private $remaining;
     private $buffer;
     private $inflate;
+    /** @var NativeClientState */
+    private $multi;
 
     /**
      * @internal
@@ -164,7 +166,7 @@ private function open(): void
     /**
      * {@inheritdoc}
      */
-    private function close(): void
+    protected function close(): void
     {
         unset($this->multi->openHandles[$this->id], $this->multi->handlesActivity[$this->id]);
         $this->handle = $this->buffer = $this->inflate = $this->onProgress = null;
@@ -173,7 +175,7 @@ private function close(): void
     /**
      * {@inheritdoc}
      */
-    private static function schedule(self $response, array &$runningResponses): void
+    protected static function schedule(self $response, array &$runningResponses): void
     {
         if (!isset($runningResponses[$i = $response->multi->id])) {
             $runningResponses[$i] = [$response->multi, []];
@@ -197,7 +199,7 @@ private static function schedule(self $response, array &$runningResponses): void
      *
      * @param NativeClientState $multi
      */
-    private static function perform(AbstractClientState $multi, array &$responses = null): void
+    protected static function perform(AbstractClientState $multi, array &$responses = null): void
     {
         // List of native handles for stream_select()
         if (null !== $responses) {
@@ -287,6 +289,7 @@ private static function perform(AbstractClientState $multi, array &$responses =
 
         if ($multi->pendingResponses && \count($multi->handles) < $multi->maxHostConnections) {
             // Open the next pending request - this is a blocking operation so we do only one of them
+            /** @var self $response */
             $response = array_shift($multi->pendingResponses);
             $response->open();
             $responses[$response->id] = $response;
diff --git a/src/Symfony/Component/HttpClient/Response/ResponseTrait.php b/src/Symfony/Component/HttpClient/Response/ResponseTrait.php
@@ -50,8 +50,7 @@ trait ResponseTrait
         'error' => null,
     ];
 
-    /** @var AbstractClientState */
-    private $multi;
+    /** @var resource */
     private $handle;
     private $id;
     private $timeout;
