bug #16312 [HttpKernel] clearstatcache() so the Cache sees when a .lck file has been released (mpdude)

fabpot · fabpot · commit b2899a6c2e71 · 2015-11-28T11:48:57.000+01:00
This PR was squashed before being merged into the 2.3 branch (closes #16312). Discussion ---------- [HttpKernel] clearstatcache() so the Cache sees when a .lck file has been released | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15813 | License | MIT | Doc PR | n/a I've been trying to debug #15813 and modified the Store in a way to keep unique request IDs in the .lck file. That way, I was hoping to find out which request is blocking and/or if the request is actually still running. It turned out that `is_file()` would claim that a lock file still exists, but a subsequent attempt to read the information from that file returned "file not found" errors. So, my assumption is that the `is_file()` result is based on the fstat cache and wrong once a process has seen the lock file. @jakzal said in #15813 (comment) that `unlink()`ing the lock file should clear the statcache, but I doubt this is true across PHP processes. Commits ------- 982710f [HttpKernel] clearstatcache() so the Cache sees when a .lck file has been released
diff --git a/src/Symfony/Component/HttpKernel/HttpCache/Store.php b/src/Symfony/Component/HttpKernel/HttpCache/Store.php
@@ -110,7 +110,10 @@ public function unlock(Request $request)
 
     public function isLocked(Request $request)
     {
-        return is_file($this->getPath($this->getCacheKey($request).'.lck'));
+        $path = $this->getPath($this->getCacheKey($request).'.lck');
+        clearstatcache(true, $path);
+
+        return is_file($path);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,10 @@ public function unlock(Request $request)`
`110`	`110`
`111`	`111`	`public function isLocked(Request $request)`
`112`	`112`	`{`
`113`		`- return is_file($this->getPath($this->getCacheKey($request).'.lck'));`
	`113`	`+ $path = $this->getPath($this->getCacheKey($request).'.lck');`
	`114`	`+ clearstatcache(true, $path);`
	`115`	`+`
	`116`	`+ return is_file($path);`
`114`	`117`	`}`
`115`	`118`
`116`	`119`	`/**`