bug #57663 [Cache] use copy() instead of rename() on Windows (xabbuh)

nicolas-grekas · nicolas-grekas · commit b437362fa34e · 2024-07-06T15:20:49.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [Cache] use copy() instead of rename() on Windows | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #50326 | License | MIT On Windows depending on the PHP version `rename()` can fail if the target file is being executed. Since the source file is not used by another process using `copy()` instead should be safe to be used. Commits ------- 6cfef7e use copy() instead of rename() on Windows
diff --git a/src/Symfony/Component/Cache/Traits/FilesystemCommonTrait.php b/src/Symfony/Component/Cache/Traits/FilesystemCommonTrait.php
@@ -114,8 +114,13 @@ private function write(string $file, string $data, ?int $expiresAt = null)
                 touch($this->tmp, $expiresAt ?: time() + 31556952); // 1 year in seconds
             }
 
-            $success = rename($this->tmp, $file);
-            $unlink = !$success;
+            if ('\\' === \DIRECTORY_SEPARATOR) {
+                $success = copy($this->tmp, $file);
+                $unlink = true;
+            } else {
+                $success = rename($this->tmp, $file);
+                $unlink = !$success;
+            }
 
             return $success;
         } finally {
