bug #21064 [Debug] Wrap call to ->log in a try catch block (lyrixx)

nicolas-grekas · nicolas-grekas · commit b4ed15a44702 · 2016-12-28T08:43:34.000+01:00
This PR was merged into the 2.7 branch.

Discussion
----------

[Debug] Wrap call to -&gt;log in a try catch block

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

---

If something goes wrong in the logger, the application ends up with a blank page. Let's display the original exception.

Commits
-------

18dfef1 [Debug] Wrap call to -&gt;log in a try catch block
diff --git a/src/Symfony/Component/Debug/ErrorHandler.php b/src/Symfony/Component/Debug/ErrorHandler.php
@@ -504,7 +504,11 @@ public function handleException($exception, array $error = null)
             }
         }
         if ($this->loggedErrors & $type) {
-            $this->loggers[$type][0]->log($this->loggers[$type][1], $message, $e);
+            try {
+                $this->loggers[$type][0]->log($this->loggers[$type][1], $message, $e);
+            } catch (\Exception $handlerException) {
+            } catch (\Throwable $handlerException) {
+            }
         }
         if ($exception instanceof FatalErrorException && !$exception instanceof OutOfMemoryException && $error) {
             foreach ($this->getFatalErrorHandlers() as $handler) {

Original file line number	Diff line number	Diff line change
`@@ -504,7 +504,11 @@ public function handleException($exception, array $error = null)`
`504`	`504`	`}`
`505`	`505`	`}`
`506`	`506`	`if ($this->loggedErrors & $type) {`
`507`		`- $this->loggers[$type][0]->log($this->loggers[$type][1], $message, $e);`
	`507`	`+ try {`
	`508`	`+ $this->loggers[$type][0]->log($this->loggers[$type][1], $message, $e);`
	`509`	`+ } catch (\Exception $handlerException) {`
	`510`	`+ } catch (\Throwable $handlerException) {`
	`511`	`+ }`
`508`	`512`	`}`
`509`	`513`	`if ($exception instanceof FatalErrorException && !$exception instanceof OutOfMemoryException && $error) {`
`510`	`514`	`foreach ($this->getFatalErrorHandlers() as $handler) {`