bug #44028 [ErrorHandler] Fix FlattenException::setPrevious argument typing (welcoMattic)

fabpot · fabpot · commit b560ec4a1d11 · 2021-11-12T19:16:56.000+01:00
This PR was merged into the 4.4 branch. Discussion ---------- [ErrorHandler] Fix FlattenException::setPrevious argument typing | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Tickets | Fix #44024  | License | MIT | Doc PR |  The setter didn't accept `null` value, while the getter can return `null`. It can be a fix for the linked issue, but I'm not 100% sure about the cause of the issue (I'll try to make a reproducer soon). In the meantime, this typing bug seems to fix at least the case explained in the issue. Commits ------- 64143dd Fix FlattenException::setPrevious argument typing
diff --git a/src/Symfony/Component/ErrorHandler/Exception/FlattenException.php b/src/Symfony/Component/ErrorHandler/Exception/FlattenException.php
@@ -276,7 +276,7 @@ public function getPrevious()
     /**
      * @return $this
      */
-    final public function setPrevious(LegacyFlattenException $previous): self
+    final public function setPrevious(?LegacyFlattenException $previous): self
     {
         $this->previous = $previous;
 

Original file line number	Diff line number	Diff line change
`@@ -276,7 +276,7 @@ public function getPrevious()`
`276`	`276`	`/**`
`277`	`277`	`* @return $this`
`278`	`278`	`*/`
`279`		`- final public function setPrevious(LegacyFlattenException $previous): self`
	`279`	`+ final public function setPrevious(?LegacyFlattenException $previous): self`
`280`	`280`	`{`
`281`	`281`	`$this->previous = $previous;`
`282`	`282`