feature #23402 [Ldap] Remove the RenameEntryInterface interface (maidmaid)

fabpot · fabpot · commit b9d93c8a2a6d · 2017-07-06T09:30:00.000+03:00
This PR was merged into the 4.0-dev branch. Discussion ---------- [Ldap] Remove the RenameEntryInterface interface | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20390 | License | MIT | Doc PR | / Commits ------- 5d35184 Remove the RenameEntryInterface interface
diff --git a/src/Symfony/Component/Ldap/Adapter/EntryManagerInterface.php b/src/Symfony/Component/Ldap/Adapter/EntryManagerInterface.php
@@ -20,6 +20,7 @@
  *
  * @author Charles Sarrazin <charles@sarraz.in>
  * @author Bob van de Vijver <bobvandevijver@hotmail.com>
+ * @author Kevin Schuurmans <kevin.schuurmans@freshheads.com>
  */
 interface EntryManagerInterface
 {
@@ -43,6 +44,15 @@ public function add(Entry $entry);
      */
     public function update(Entry $entry);
 
+    /**
+     * Renames an entry on the Ldap server.
+     *
+     * @param Entry  $entry
+     * @param string $newRdn
+     * @param bool   $removeOldRdn
+     */
+    public function rename(Entry $entry, $newRdn, $removeOldRdn = true);
+
     /**
      * Removes an entry from the Ldap server.
      *
diff --git a/src/Symfony/Component/Ldap/Adapter/ExtLdap/EntryManager.php b/src/Symfony/Component/Ldap/Adapter/ExtLdap/EntryManager.php
@@ -12,7 +12,6 @@
 namespace Symfony\Component\Ldap\Adapter\ExtLdap;
 
 use Symfony\Component\Ldap\Adapter\EntryManagerInterface;
-use Symfony\Component\Ldap\Adapter\RenameEntryInterface;
 use Symfony\Component\Ldap\Entry;
 use Symfony\Component\Ldap\Exception\LdapException;
 use Symfony\Component\Ldap\Exception\NotBoundException;
@@ -21,7 +20,7 @@
  * @author Charles Sarrazin <charles@sarraz.in>
  * @author Bob van de Vijver <bobvandevijver@hotmail.com>
  */
-class EntryManager implements EntryManagerInterface, RenameEntryInterface
+class EntryManager implements EntryManagerInterface
 {
     private $connection;
 
diff --git a/src/Symfony/Component/Ldap/Adapter/RenameEntryInterface.php b/src/Symfony/Component/Ldap/Adapter/RenameEntryInterface.php
diff --git a/src/Symfony/Component/Ldap/CHANGELOG.md b/src/Symfony/Component/Ldap/CHANGELOG.md
@@ -5,6 +5,7 @@ CHANGELOG
 -----
 
  * removed the `LdapClient` class and the `LdapClientInterface`
+ * removed the `RenameEntryInterface` interface and merged with `EntryManagerInterface`
 
 3.1.0
 -----
