bug #41990 [Lock] fix derivating semaphore from key (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit ba7e97d528c1 · 2021-07-05T15:23:55.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [Lock] fix derivating semaphore from key | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Commits ------- d9dea8d [Lock] fix derivating semaphore from key
diff --git a/src/Symfony/Component/Lock/Store/SemaphoreStore.php b/src/Symfony/Component/Lock/Store/SemaphoreStore.php
@@ -63,7 +63,7 @@ private function lock(Key $key, bool $blocking)
             return;
         }
 
-        $keyId = crc32($key);
+        $keyId = unpack('i', md5($key, true))[1];
         $resource = sem_get($keyId);
         $acquired = @sem_acquire($resource, !$blocking);
 

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ private function lock(Key $key, bool $blocking)`
`63`	`63`	`return;`
`64`	`64`	`}`
`65`	`65`
`66`		`- $keyId = crc32($key);`
	`66`	`+ $keyId = unpack('i', md5($key, true))[1];`
`67`	`67`	`$resource = sem_get($keyId);`
`68`	`68`	`$acquired = @sem_acquire($resource, !$blocking);`
`69`	`69`