bug #26230 [WebProfilerBundle] Fix anchor CSS (ro0NL)

nicolas-grekas · nicolas-grekas · commit ba8a68f0551e · 2018-02-19T17:27:38.000+01:00
This PR was squashed before being merged into the 3.4 branch (closes #26230). Discussion ---------- [WebProfilerBundle] Fix anchor CSS | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes/no | Fixed tickets | #...  | License | MIT | Doc PR | symfony/symfony-docs#...  Empty source lines overlap in `/_profiler/open?file=x`. AFAIK it's a regression after #23296, but it's the first time i noticed so maybe it's related to a chrome change in between. No real CSS expert.. but this seems to fix it. Before: ![image](https://user-images.githubusercontent.com/1047696/36377240-ba3f897a-1576-11e8-8660-8b04a6f7bd76.png) After: ![image](https://user-images.githubusercontent.com/1047696/36377574-f99bd73a-1577-11e8-913c-d4287d5115a2.png) I can confirm both chrome and firefox render as shown in the after screenshot. Firefox worked before as well, chrome not. cc @ogizanagi Commits ------- ee45992 [WebProfilerBundle] Fix anchor CSS
diff --git a/src/Symfony/Bridge/Twig/Extension/CodeExtension.php b/src/Symfony/Bridge/Twig/Extension/CodeExtension.php
@@ -259,6 +259,6 @@ protected static function fixCodeMarkup($line)
             $line .= '</span>';
         }
 
-        return $line;
+        return trim($line);
     }
 }
diff --git a/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/open.css.twig b/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/open.css.twig
@@ -68,7 +68,7 @@ a.doc:hover {
 
 .anchor {
     position: relative;
-    display: block;
+    display: inline-block;
     top: -7em;
     visibility: hidden;
 }

Original file line number	Diff line number	Diff line change
`@@ -259,6 +259,6 @@ protected static function fixCodeMarkup($line)`
`259`	`259`	`$line .= '</span>';`
`260`	`260`	`}`
`261`	`261`
`262`		`- return $line;`
	`262`	`+ return trim($line);`
`263`	`263`	`}`
`264`	`264`	`}`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ a.doc:hover {`
`68`	`68`
`69`	`69`	`.anchor {`
`70`	`70`	`position: relative;`
`71`		`- display: block;`
	`71`	`+ display: inline-block;`
`72`	`72`	`top: -7em;`
`73`	`73`	`visibility: hidden;`
`74`	`74`	`}`