Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit bad5680

Browse files
srozesroze
committed
minor #27163 [Messenger] Rename TolerateNoHandler to AllowNoHandlerMiddleware (nicolas-grekas)
This PR was merged into the 4.1-dev branch. Discussion ---------- [Messenger] Rename TolerateNoHandler to AllowNoHandlerMiddleware | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I was surprised by the word "tolerate", and by the missing "middleware" suffix. This way would be less surprizing I believe. Commits ------- 5434780 [Messenger] Rename TolerateNoHandler to AllowNoHandlerMiddleware
2 parents cada38f + 5434780 commit bad5680

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

‎src/Symfony/Component/Messenger/Middleware/TolerateNoHandler.php renamed to ‎src/Symfony/Component/Messenger/Middleware/AllowNoHandlerMiddleware.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@
1616
/**
1717
* @author Samuel Roze <[email protected]>
1818
*/
19-
class TolerateNoHandler implements MiddlewareInterface
19+
class AllowNoHandlerMiddleware implements MiddlewareInterface
2020
{
2121
public function handle($message, callable $next)
2222
{
2323
try {
2424
return $next($message);
2525
} catch (NoHandlerForMessageException $e) {
26-
// We tolerate not having a handler for this message.
26+
// We allow not having a handler for this message.
2727
}
2828
}
2929
}

‎src/Symfony/Component/Messenger/Tests/DependencyInjection/MessengerPassTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
use Symfony\Component\Messenger\Handler\ChainHandler;
2525
use Symfony\Component\Messenger\Handler\MessageSubscriberInterface;
2626
use Symfony\Component\Messenger\MessageBusInterface;
27-
use Symfony\Component\Messenger\Middleware\TolerateNoHandler;
27+
use Symfony\Component\Messenger\Middleware\AllowNoHandlerMiddleware;
2828
use Symfony\Component\Messenger\Middleware\MiddlewareInterface;
2929
use Symfony\Component\Messenger\Tests\Fixtures\DummyMessage;
3030
use Symfony\Component\Messenger\Tests\Fixtures\SecondMessage;
@@ -264,14 +264,14 @@ public function testRegistersMiddlewaresFromServices()
264264
{
265265
$container = $this->getContainerBuilder();
266266
$container->register($fooBusId = 'messenger.bus.foo', MessageBusInterface::class)->setArgument(0, array())->addTag('messenger.bus', array('name' => 'foo'));
267-
$container->register('messenger.middleware.tolerate_no_handler', TolerateNoHandler::class)->setAbstract(true);
267+
$container->register('messenger.middleware.allow_no_handler', AllowNoHandlerMiddleware::class)->setAbstract(true);
268268
$container->register(UselessMiddleware::class, UselessMiddleware::class);
269269

270-
$container->setParameter($middlewaresParameter = $fooBusId.'.middlewares', array(UselessMiddleware::class, 'tolerate_no_handler'));
270+
$container->setParameter($middlewaresParameter = $fooBusId.'.middlewares', array(UselessMiddleware::class, 'allow_no_handler'));
271271

272272
(new MessengerPass())->process($container);
273273

274-
$this->assertTrue($container->hasDefinition($childMiddlewareId = $fooBusId.'.middleware.tolerate_no_handler'));
274+
$this->assertTrue($container->hasDefinition($childMiddlewareId = $fooBusId.'.middleware.allow_no_handler'));
275275
$this->assertEquals(array(new Reference(UselessMiddleware::class), new Reference($childMiddlewareId)), $container->getDefinition($fooBusId)->getArgument(0));
276276
$this->assertFalse($container->hasParameter($middlewaresParameter));
277277
}

‎src/Symfony/Component/Messenger/Tests/Middleware/TolerateNoHandlerTest.php renamed to ‎src/Symfony/Component/Messenger/Tests/Middleware/AllowNoHandlerMiddlewareTest.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@
1313

1414
use PHPUnit\Framework\TestCase;
1515
use Symfony\Component\Messenger\Exception\NoHandlerForMessageException;
16-
use Symfony\Component\Messenger\Middleware\TolerateNoHandler;
16+
use Symfony\Component\Messenger\Middleware\AllowNoHandlerMiddleware;
1717
use Symfony\Component\Messenger\Tests\Fixtures\DummyMessage;
1818

19-
class TolerateNoHandlerTest extends TestCase
19+
class AllowNoHandlerMiddlewareTest extends TestCase
2020
{
2121
public function testItCallsNextMiddlewareAndReturnsItsResult()
2222
{
@@ -25,7 +25,7 @@ public function testItCallsNextMiddlewareAndReturnsItsResult()
2525
$next = $this->createPartialMock(\stdClass::class, array('__invoke'));
2626
$next->expects($this->once())->method('__invoke')->with($message)->willReturn('Foo');
2727

28-
$middleware = new TolerateNoHandler();
28+
$middleware = new AllowNoHandlerMiddleware();
2929
$this->assertSame('Foo', $middleware->handle($message, $next));
3030
}
3131

@@ -34,7 +34,7 @@ public function testItCatchesTheNoHandlerException()
3434
$next = $this->createPartialMock(\stdClass::class, array('__invoke'));
3535
$next->expects($this->once())->method('__invoke')->will($this->throwException(new NoHandlerForMessageException()));
3636

37-
$middleware = new TolerateNoHandler();
37+
$middleware = new AllowNoHandlerMiddleware();
3838

3939
$this->assertNull($middleware->handle(new DummyMessage('Hey'), $next));
4040
}
@@ -48,7 +48,7 @@ public function testItDoesNotCatchOtherExceptions()
4848
$next = $this->createPartialMock(\stdClass::class, array('__invoke'));
4949
$next->expects($this->once())->method('__invoke')->will($this->throwException(new \RuntimeException('Something went wrong.')));
5050

51-
$middleware = new TolerateNoHandler();
51+
$middleware = new AllowNoHandlerMiddleware();
5252
$middleware->handle(new DummyMessage('Hey'), $next);
5353
}
5454
}

0 commit comments

Comments
 (0)