Rename the interface to NormalizerWithCacheableSupportResultInterface

dunglas · dunglas · commit bbb4d4e6f993 · 2018-04-27T12:15:42.000+02:00
diff --git a/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
@@ -30,7 +30,7 @@
  *
  * @author Kévin Dunglas <dunglas@gmail.com>
  */
-abstract class AbstractObjectNormalizer extends AbstractNormalizer implements ContextFreeCacheNormalizerInterface
+abstract class AbstractObjectNormalizer extends AbstractNormalizer implements NormalizerWithCacheableSupportResultInterface
 {
     const ENABLE_MAX_DEPTH = 'enable_max_depth';
     const DEPTH_KEY_PATTERN = 'depth_%s::%s';
diff --git a/src/Symfony/Component/Serializer/Normalizer/ConstraintViolationListNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/ConstraintViolationListNormalizer.php
@@ -22,7 +22,7 @@
  * @author Grégoire Pineau <lyrixx@lyrixx.info>
  * @author Kévin Dunglas <dunglas@gmail.com>
  */
-class ConstraintViolationListNormalizer implements NormalizerInterface, ContextFreeCacheNormalizerInterface
+class ConstraintViolationListNormalizer implements NormalizerInterface, NormalizerWithCacheableSupportResultInterface
 {
     /**
      * {@inheritdoc}
diff --git a/src/Symfony/Component/Serializer/Normalizer/CustomNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/CustomNormalizer.php
@@ -17,7 +17,7 @@
 /**
  * @author Jordi Boggiano <j.boggiano@seld.be>
  */
-class CustomNormalizer implements NormalizerInterface, DenormalizerInterface, SerializerAwareInterface, ContextFreeCacheNormalizerInterface
+class CustomNormalizer implements NormalizerInterface, DenormalizerInterface, SerializerAwareInterface, NormalizerWithCacheableSupportResultInterface
 {
     use ObjectToPopulateTrait;
     use SerializerAwareTrait;
diff --git a/src/Symfony/Component/Serializer/Normalizer/DataUriNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/DataUriNormalizer.php
@@ -23,7 +23,7 @@
  *
  * @author Kévin Dunglas <dunglas@gmail.com>
  */
-class DataUriNormalizer implements NormalizerInterface, DenormalizerInterface, ContextFreeCacheNormalizerInterface
+class DataUriNormalizer implements NormalizerInterface, DenormalizerInterface, NormalizerWithCacheableSupportResultInterface
 {
     private static $supportedTypes = array(
         \SplFileInfo::class => true,
diff --git a/src/Symfony/Component/Serializer/Normalizer/DateIntervalNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/DateIntervalNormalizer.php
@@ -20,7 +20,7 @@
  *
  * @author Jérôme Parmentier <jerome@prmntr.me>
  */
-class DateIntervalNormalizer implements NormalizerInterface, DenormalizerInterface, ContextFreeCacheNormalizerInterface
+class DateIntervalNormalizer implements NormalizerInterface, DenormalizerInterface, NormalizerWithCacheableSupportResultInterface
 {
     const FORMAT_KEY = 'dateinterval_format';
 
diff --git a/src/Symfony/Component/Serializer/Normalizer/DateTimeNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/DateTimeNormalizer.php
@@ -20,7 +20,7 @@
  *
  * @author Kévin Dunglas <dunglas@gmail.com>
  */
-class DateTimeNormalizer implements NormalizerInterface, DenormalizerInterface, ContextFreeCacheNormalizerInterface
+class DateTimeNormalizer implements NormalizerInterface, DenormalizerInterface, NormalizerWithCacheableSupportResultInterface
 {
     const FORMAT_KEY = 'datetime_format';
     const TIMEZONE_KEY = 'datetime_timezone';
diff --git a/src/Symfony/Component/Serializer/Normalizer/JsonSerializableNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/JsonSerializableNormalizer.php
@@ -19,7 +19,7 @@
  *
  * @author Fred Cox <mcfedr@gmail.com>
  */
-class JsonSerializableNormalizer extends AbstractNormalizer implements ContextFreeCacheNormalizerInterface
+class JsonSerializableNormalizer extends AbstractNormalizer implements NormalizerWithCacheableSupportResultInterface
 {
     /**
      * {@inheritdoc}
diff --git a/src/Symfony/Component/Serializer/Normalizer/NormalizerWithCacheableSupportResultInterface.php b/src/Symfony/Component/Serializer/Normalizer/NormalizerWithCacheableSupportResultInterface.php
@@ -12,10 +12,10 @@
 namespace Symfony\Component\Serializer\Normalizer;
 
 /**
- * Lets the normalizer advertise if the returns of its "supportsNormalization" method is cacheable.
+ * "supportsNormalization()" methods of normalizers implementing this interface have a cacheable return.
  *
  * @author Kévin Dunglas <dunglas@gmail.com>
  */
-interface ContextFreeCacheNormalizerInterface
+interface NormalizerWithCacheableSupportResultInterface
 {
 }
diff --git a/src/Symfony/Component/Serializer/Serializer.php b/src/Symfony/Component/Serializer/Serializer.php
@@ -26,7 +26,7 @@
 use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
 use Symfony\Component\Serializer\Normalizer\DenormalizerInterface;
 use Symfony\Component\Serializer\Exception\LogicException;
-use Symfony\Component\Serializer\Normalizer\ContextFreeCacheNormalizerInterface;
+use Symfony\Component\Serializer\Normalizer\NormalizerWithCacheableSupportResultInterface;
 
 /**
  * Serializer serializes and deserializes data.
@@ -219,7 +219,7 @@ private function getNormalizer($data, $format, array $context)
                 continue;
             }
 
-            $cacheable = $cacheable && $normalizer instanceof ContextFreeCacheNormalizerInterface;
+            $cacheable = $cacheable && $normalizer instanceof NormalizerWithCacheableSupportResultInterface;
             if ($normalizer->supportsNormalization($data, $format, $context)) {
                 if ($cacheable) {
                     $this->normalizerCache[$type][$format] = $normalizer;

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@`
`30`	`30`	`*`
`31`	`31`	`* @author Kévin Dunglas <[email protected]>`
`32`	`32`	`*/`
`33`		`-abstract class AbstractObjectNormalizer extends AbstractNormalizer implements ContextFreeCacheNormalizerInterface`
	`33`	`+abstract class AbstractObjectNormalizer extends AbstractNormalizer implements NormalizerWithCacheableSupportResultInterface`
`34`	`34`	`{`
`35`	`35`	`const ENABLE_MAX_DEPTH = 'enable_max_depth';`
`36`	`36`	`const DEPTH_KEY_PATTERN = 'depth_%s::%s';`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@`
`22`	`22`	`* @author Grégoire Pineau <[email protected]>`
`23`	`23`	`* @author Kévin Dunglas <[email protected]>`
`24`	`24`	`*/`
`25`		`-class ConstraintViolationListNormalizer implements NormalizerInterface, ContextFreeCacheNormalizerInterface`
	`25`	`+class ConstraintViolationListNormalizer implements NormalizerInterface, NormalizerWithCacheableSupportResultInterface`
`26`	`26`	`{`
`27`	`27`	`/**`
`28`	`28`	`* {@inheritdoc}`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@`
`17`	`17`	`/**`
`18`	`18`	`* @author Jordi Boggiano <[email protected]>`
`19`	`19`	`*/`
`20`		`-class CustomNormalizer implements NormalizerInterface, DenormalizerInterface, SerializerAwareInterface, ContextFreeCacheNormalizerInterface`
	`20`	`+class CustomNormalizer implements NormalizerInterface, DenormalizerInterface, SerializerAwareInterface, NormalizerWithCacheableSupportResultInterface`
`21`	`21`	`{`
`22`	`22`	`use ObjectToPopulateTrait;`
`23`	`23`	`use SerializerAwareTrait;`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@`
`23`	`23`	`*`
`24`	`24`	`* @author Kévin Dunglas <[email protected]>`
`25`	`25`	`*/`
`26`		`-class DataUriNormalizer implements NormalizerInterface, DenormalizerInterface, ContextFreeCacheNormalizerInterface`
	`26`	`+class DataUriNormalizer implements NormalizerInterface, DenormalizerInterface, NormalizerWithCacheableSupportResultInterface`
`27`	`27`	`{`
`28`	`28`	`private static $supportedTypes = array(`
`29`	`29`	`\SplFileInfo::class => true,`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@`
`20`	`20`	`*`
`21`	`21`	`* @author Jérôme Parmentier <[email protected]>`
`22`	`22`	`*/`
`23`		`-class DateIntervalNormalizer implements NormalizerInterface, DenormalizerInterface, ContextFreeCacheNormalizerInterface`
	`23`	`+class DateIntervalNormalizer implements NormalizerInterface, DenormalizerInterface, NormalizerWithCacheableSupportResultInterface`
`24`	`24`	`{`
`25`	`25`	`const FORMAT_KEY = 'dateinterval_format';`
`26`	`26`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@`
`19`	`19`	`*`
`20`	`20`	`* @author Fred Cox <[email protected]>`
`21`	`21`	`*/`
`22`		`-class JsonSerializableNormalizer extends AbstractNormalizer implements ContextFreeCacheNormalizerInterface`
	`22`	`+class JsonSerializableNormalizer extends AbstractNormalizer implements NormalizerWithCacheableSupportResultInterface`
`23`	`23`	`{`
`24`	`24`	`/**`
`25`	`25`	`* {@inheritdoc}`
Original file line number	Diff line number	Diff line change
`@@ -12,10 +12,10 @@`
`12`	`12`	`namespace Symfony\Component\Serializer\Normalizer;`
`13`	`13`
`14`	`14`	`/**`
`15`		`- * Lets the normalizer advertise if the returns of its "supportsNormalization" method is cacheable.`
	`15`	`+ * "supportsNormalization()" methods of normalizers implementing this interface have a cacheable return.`
`16`	`16`	`*`
`17`	`17`	`* @author Kévin Dunglas <[email protected]>`
`18`	`18`	`*/`
`19`		`-interface ContextFreeCacheNormalizerInterface`
	`19`	`+interface NormalizerWithCacheableSupportResultInterface`
`20`	`20`	`{`
`21`	`21`	`}`