minor #15832 [Translation][File dumper] allow new child classes to implement only formatCatalogue (aitboudad)

Tobion · Tobion · commit bcb2ff600da4 · 2015-09-18T22:35:55.000+02:00
This PR was merged into the 2.8 branch. Discussion ---------- [Translation][File dumper] allow new child classes to implement only formatCatalogue | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Fixed tickets | #15699 | Tests pass? | yes | License | MIT Commits ------- 5fd9f2f [Translation][File dumper] allow new child classes to implement only formatCatalogue.
diff --git a/src/Symfony/Component/Translation/Dumper/FileDumper.php b/src/Symfony/Component/Translation/Dumper/FileDumper.php
@@ -114,7 +114,10 @@ protected function formatCatalogue(MessageCatalogue $messages, $domain, array $o
      *
      * @deprecated since version 2.8, to be removed in 3.0. Overwrite formatCatalogue() instead.
      */
-    abstract protected function format(MessageCatalogue $messages, $domain);
+    protected function format(MessageCatalogue $messages, $domain)
+    {
+        throw new \LogicException('The "FileDumper::format" method needs to be overwritten, you should implement either "format" or "formatCatalogue".');
+    }
 
     /**
      * Gets the file extension of the dumper.
diff --git a/src/Symfony/Component/Translation/Tests/Dumper/FileDumperTest.php b/src/Symfony/Component/Translation/Tests/Dumper/FileDumperTest.php
@@ -63,11 +63,6 @@ protected function formatCatalogue(MessageCatalogue $messages, $domain, array $o
         return '';
     }
 
-    protected function format(MessageCatalogue $messages, $domain)
-    {
-        return $this->formatCatalogue($messages, $domain);
-    }
-
     protected function getExtension()
     {
         return 'concrete';

Original file line number	Diff line number	Diff line change
`@@ -63,11 +63,6 @@ protected function formatCatalogue(MessageCatalogue $messages, $domain, array $o`
`63`	`63`	`return '';`
`64`	`64`	`}`
`65`	`65`
`66`		`- protected function format(MessageCatalogue $messages, $domain)`
`67`		`- {`
`68`		`- return $this->formatCatalogue($messages, $domain);`
`69`		`- }`
`70`		`-`
`71`	`66`	`protected function getExtension()`
`72`	`67`	`{`
`73`	`68`	`return 'concrete';`