fix tests that are no longer valid with PHP >= 8.2.18/8.3.5

xabbuh · xabbuh · commit bd08301ff358 · 2024-04-13T09:04:03.000+02:00
diff --git a/src/Symfony/Component/PasswordHasher/Tests/Hasher/NativePasswordHasherTest.php b/src/Symfony/Component/PasswordHasher/Tests/Hasher/NativePasswordHasherTest.php
@@ -100,6 +100,10 @@ public function testBcryptWithLongPassword()
 
     public function testBcryptWithNulByte()
     {
+        if (\PHP_VERSION_ID >= 80218 && \PHP_VERSION_ID < 80300 || \PHP_VERSION_ID > 80305) {
+            $this->markTestSkipped('password_hash() does not accept plain passwords containing null bytes since PHP 8.2.18 and 8.3.5');
+        }
+
         $hasher = new NativePasswordHasher(null, null, 4, \PASSWORD_BCRYPT);
         $plainPassword = "a\0b";
 
diff --git a/src/Symfony/Component/PasswordHasher/Tests/Hasher/SodiumPasswordHasherTest.php b/src/Symfony/Component/PasswordHasher/Tests/Hasher/SodiumPasswordHasherTest.php
@@ -75,6 +75,10 @@ public function testBcryptWithLongPassword()
 
     public function testBcryptWithNulByte()
     {
+        if (\PHP_VERSION_ID >= 80218 && \PHP_VERSION_ID < 80300 || \PHP_VERSION_ID > 80305) {
+            $this->markTestSkipped('password_hash() does not accept plain passwords containing null bytes since PHP 8.2.18 and 8.3.5');
+        }
+
         $hasher = new SodiumPasswordHasher(null, null);
         $plainPassword = "a\0b";
 

Original file line number	Diff line number	Diff line change
`@@ -100,6 +100,10 @@ public function testBcryptWithLongPassword()`
`100`	`100`
`101`	`101`	`public function testBcryptWithNulByte()`
`102`	`102`	`{`
	`103`	`+ if (\PHP_VERSION_ID >= 80218 && \PHP_VERSION_ID < 80300 \|\| \PHP_VERSION_ID > 80305) {`
	`104`	`+ $this->markTestSkipped('password_hash() does not accept plain passwords containing null bytes since PHP 8.2.18 and 8.3.5');`
	`105`	`+ }`
	`106`	`+`
`103`	`107`	`$hasher = new NativePasswordHasher(null, null, 4, \PASSWORD_BCRYPT);`
`104`	`108`	`$plainPassword = "a\0b";`
`105`	`109`
Original file line number	Diff line number	Diff line change
`@@ -75,6 +75,10 @@ public function testBcryptWithLongPassword()`
`75`	`75`
`76`	`76`	`public function testBcryptWithNulByte()`
`77`	`77`	`{`
	`78`	`+ if (\PHP_VERSION_ID >= 80218 && \PHP_VERSION_ID < 80300 \|\| \PHP_VERSION_ID > 80305) {`
	`79`	`+ $this->markTestSkipped('password_hash() does not accept plain passwords containing null bytes since PHP 8.2.18 and 8.3.5');`
	`80`	`+ }`
	`81`	`+`
`78`	`82`	`$hasher = new SodiumPasswordHasher(null, null);`
`79`	`83`	`$plainPassword = "a\0b";`
`80`	`84`