added some validation

fabpot · fabpot · commit be3ec9780f7b · 2018-04-04T08:24:09.000+02:00
diff --git a/src/Symfony/Bridge/Monolog/Handler/FingersCrossed/HttpCodeActivationStrategy.php b/src/Symfony/Bridge/Monolog/Handler/FingersCrossed/HttpCodeActivationStrategy.php
@@ -27,6 +27,15 @@ class HttpCodeActivationStrategy extends ErrorLevelActivationStrategy
 
     public function __construct(RequestStack $requestStack, array $exclusions, $actionLevel)
     {
+        foreach ($exclusions as $exclusion) {
+            if (!array_key_exists('code', $exclusion)) {
+                throw new \LogicException(sprintf('An exclusion must have a "code" key'));
+            }
+            if (!array_key_exists('urls', $exclusion)) {
+                throw new \LogicException(sprintf('An exclusion must have a "urls" key'));
+            }
+        }
+
         parent::__construct($actionLevel);
 
         $this->requestStack = $requestStack;
@@ -49,8 +58,8 @@ public function isHandlerActivated(array $record)
                 }
 
                 $urlBlacklist = null;
-                if (count($exclusion['url'])) {
-                    return !preg_match('{('.implode('|', $exclusion['url']).')}i', $request->getPathInfo());
+                if (count($exclusion['urls'])) {
+                    return !preg_match('{('.implode('|', $exclusion['urls']).')}i', $request->getPathInfo());
                 }
 
                 return false;
diff --git a/src/Symfony/Bridge/Monolog/Tests/Handler/FingersCrossed/HttpCodeActivationStrategyTest.php b/src/Symfony/Bridge/Monolog/Tests/Handler/FingersCrossed/HttpCodeActivationStrategyTest.php
@@ -31,10 +31,10 @@ public function testIsActivated($url, $record, $expected)
         $strategy = new HttpCodeActivationStrategy(
             $requestStack,
             array(
-                array('code' => 403, 'url' => array()),
-                array('code' => 404, 'url' => array()),
-                array('code' => 405, 'url' => array()),
-                array('code' => 400, 'url' => array('^/400/a', '^/400/b')),
+                array('code' => 403, 'urls' => array()),
+                array('code' => 404, 'urls' => array()),
+                array('code' => 405, 'urls' => array()),
+                array('code' => 400, 'urls' => array('^/400/a', '^/400/b')),
             ),
             Logger::WARNING
         );
