[Security] Readd deprecated methods to the interfaces

wouterj · wouterj · commit c23455e51a6c · 2021-06-01T15:31:27.000+02:00
diff --git a/src/Symfony/Bridge/Doctrine/Security/User/UserLoaderInterface.php b/src/Symfony/Bridge/Doctrine/Security/User/UserLoaderInterface.php
@@ -29,4 +29,8 @@
  */
 interface UserLoaderInterface
 {
+    /**
+     * @deprecated since Symfony 5.3, use loadUserByIdentifier() instead
+     */
+    public function loadUserByUsername(string $username);
 }
diff --git a/src/Symfony/Component/Security/Core/Authentication/RememberMe/PersistentTokenInterface.php b/src/Symfony/Component/Security/Core/Authentication/RememberMe/PersistentTokenInterface.php
@@ -48,4 +48,9 @@ public function getTokenValue();
      * @return \DateTime
      */
     public function getLastUsed();
+
+    /**
+     * @deprecated since Symfony 5.3, use getUserIdentifier() instead
+     */
+    public function getUsername();
 }
diff --git a/src/Symfony/Component/Security/Core/Authentication/Token/TokenInterface.php b/src/Symfony/Component/Security/Core/Authentication/Token/TokenInterface.php
@@ -130,4 +130,9 @@ public function __serialize(): array;
      * Restores the object state from an array given by __serialize().
      */
     public function __unserialize(array $data): void;
+
+    /**
+     * @deprecated since Symfony 5.3, use getUserIdentifier() instead
+     */
+    public function getUsername();
 }
diff --git a/src/Symfony/Component/Security/Core/User/UserInterface.php b/src/Symfony/Component/Security/Core/User/UserInterface.php
@@ -78,4 +78,9 @@ public function getSalt();
      * the plain-text password is stored on this object.
      */
     public function eraseCredentials();
+
+    /**
+     * @deprecated since Symfony 5.3, use getUserIdentifier() instead
+     */
+    public function getUsername();
 }
diff --git a/src/Symfony/Component/Security/Core/User/UserProviderInterface.php b/src/Symfony/Component/Security/Core/User/UserProviderInterface.php
@@ -57,4 +57,9 @@ public function refreshUser(UserInterface $user);
      * @return bool
      */
     public function supportsClass(string $class);
+
+    /**
+     * @deprecated since Symfony 5.3, use loadUserByIdentifier() instead
+     */
+    public function loadUserByUsername(string $username);
 }
diff --git a/src/Symfony/Component/Security/Http/Tests/LoginLink/LoginLinkHandlerTest.php b/src/Symfony/Component/Security/Http/Tests/LoginLink/LoginLinkHandlerTest.php
@@ -211,6 +211,11 @@ public function createUser(TestLoginLinkHandlerUser $user): void
         $this->users[$user->getUserIdentifier()] = $user;
     }
 
+    public function loadUserByUsername($username): TestLoginLinkHandlerUser
+    {
+        return $this->loadUserByIdentifier($username);
+    }
+
     public function loadUserByIdentifier(string $userIdentifier): TestLoginLinkHandlerUser
     {
         if (!isset($this->users[$userIdentifier])) {

Original file line number	Diff line number	Diff line change
`@@ -29,4 +29,8 @@`
`29`	`29`	`*/`
`30`	`30`	`interface UserLoaderInterface`
`31`	`31`	`{`
	`32`	`+ /**`
	`33`	`+ * @deprecated since Symfony 5.3, use loadUserByIdentifier() instead`
	`34`	`+ */`
	`35`	`+ public function loadUserByUsername(string $username);`
`32`	`36`	`}`
Original file line number	Diff line number	Diff line change
`@@ -211,6 +211,11 @@ public function createUser(TestLoginLinkHandlerUser $user): void`
`211`	`211`	`$this->users[$user->getUserIdentifier()] = $user;`
`212`	`212`	`}`
`213`	`213`
	`214`	`+ public function loadUserByUsername($username): TestLoginLinkHandlerUser`
	`215`	`+ {`
	`216`	`+ return $this->loadUserByIdentifier($username);`
	`217`	`+ }`
	`218`	`+`
`214`	`219`	`public function loadUserByIdentifier(string $userIdentifier): TestLoginLinkHandlerUser`
`215`	`220`	`{`
`216`	`221`	`if (!isset($this->users[$userIdentifier])) {`