bug #49172 [HttpFoundation] Fix defining expiry index in PdoSessionHandler::configureSchema() (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit c24cf107e7f9 · 2023-02-01T19:12:22.000+01:00
This PR was merged into the 6.3 branch. Discussion ---------- [HttpFoundation] Fix defining expiry index in PdoSessionHandler::configureSchema() | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Forgotten in #48059 Commits ------- 1a67728 [HttpFoundation] Fix defining expiry index in PdoSessionHandler::configureSchema()
diff --git a/src/Symfony/Component/HttpFoundation/Session/Storage/Handler/PdoSessionHandler.php b/src/Symfony/Component/HttpFoundation/Session/Storage/Handler/PdoSessionHandler.php
@@ -225,6 +225,7 @@ public function configureSchema(Schema $schema, \Closure $isSameDatabase = null)
                 throw new \DomainException(sprintf('Creating the session table is currently not implemented for PDO driver "%s".', $this->driver));
         }
         $table->setPrimaryKey([$this->idCol]);
+        $table->addIndex([$this->lifetimeCol], $this->lifetimeCol.'_idx');
     }
 
     /**
@@ -259,7 +260,7 @@ public function createTable()
 
         try {
             $this->pdo->exec($sql);
-            $this->pdo->exec("CREATE INDEX expiry ON $this->table ($this->lifetimeCol)");
+            $this->pdo->exec("CREATE INDEX {$this->lifetimeCol}_idx ON $this->table ($this->lifetimeCol)");
         } catch (\PDOException $e) {
             $this->rollback();
 

Original file line number	Diff line number	Diff line change
`@@ -225,6 +225,7 @@ public function configureSchema(Schema $schema, \Closure $isSameDatabase = null)`
`225`	`225`	`throw new \DomainException(sprintf('Creating the session table is currently not implemented for PDO driver "%s".', $this->driver));`
`226`	`226`	`}`
`227`	`227`	`$table->setPrimaryKey([$this->idCol]);`
	`228`	`+ $table->addIndex([$this->lifetimeCol], $this->lifetimeCol.'_idx');`
`228`	`229`	`}`
`229`	`230`
`230`	`231`	`/**`
`@@ -259,7 +260,7 @@ public function createTable()`
`259`	`260`
`260`	`261`	`try {`
`261`	`262`	`$this->pdo->exec($sql);`
`262`		`- $this->pdo->exec("CREATE INDEX expiry ON $this->table ($this->lifetimeCol)");`
	`263`	`+ $this->pdo->exec("CREATE INDEX {$this->lifetimeCol}_idx ON $this->table ($this->lifetimeCol)");`
`263`	`264`	`} catch (\PDOException $e) {`
`264`	`265`	`$this->rollback();`
`265`	`266`