bug #46730 [Intl] Fix the IntlDateFormatter::formatObject signature (damienalexandre)

fabpot · fabpot · commit c2990690d088 · 2022-06-22T20:08:39.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [Intl] Fix the IntlDateFormatter::formatObject signature | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | None | License | MIT | Doc PR | 🕳️ I was calling `IntlDateFormatter::formatObject` in my user-land code and got this error from PHPStan: ``` Static call to instance method Symfony\Component\Intl\DateFormatter\IntlDateFormatter::formatObject(). ``` The Intl component `formatObject` method signature is indeed non-static, but the PHP Intl signature is. Reference: https://www.php.net/manual/en/intldateformatter.formatobject.php So I think the component should respect PHP method signature. Commits ------- 22cd9cb [Intl] Fix the IntlDateFormatter::formatObject signature
diff --git a/src/Symfony/Component/Intl/DateFormatter/IntlDateFormatter.php b/src/Symfony/Component/Intl/DateFormatter/IntlDateFormatter.php
@@ -243,7 +243,7 @@ public function format($timestamp)
      *
      * @throws MethodNotImplementedException
      */
-    public function formatObject($object, $format = null, $locale = null)
+    public static function formatObject($object, $format = null, $locale = null)
     {
         throw new MethodNotImplementedException(__METHOD__);
     }

Original file line number	Diff line number	Diff line change
`@@ -243,7 +243,7 @@ public function format($timestamp)`
`243`	`243`	`*`
`244`	`244`	`* @throws MethodNotImplementedException`
`245`	`245`	`*/`
`246`		`- public function formatObject($object, $format = null, $locale = null)`
	`246`	`+ public static function formatObject($object, $format = null, $locale = null)`
`247`	`247`	`{`
`248`	`248`	`throw new MethodNotImplementedException(__METHOD__);`
`249`	`249`	`}`