Improve error reporting during LDAP bind

RoSk0 · RoSk0 · commit c3cd264ee4d4 · 2024-04-15T14:55:03.000+12:00
Based on the https://www.php.net/manual/en/function.ldap-error.php#121881
diff --git a/src/Symfony/Component/Ldap/Adapter/ExtLdap/Connection.php b/src/Symfony/Component/Ldap/Adapter/ExtLdap/Connection.php
@@ -78,7 +78,8 @@ public function bind(?string $dn = null, #[\SensitiveParameter] ?string $passwor
                 case self::LDAP_ALREADY_EXISTS:
                     throw new AlreadyExistsException($error);
             }
-            throw new ConnectionException($error);
+            ldap_get_option($this->connection, LDAP_OPT_DIAGNOSTIC_MESSAGE, $diagnostic_message);
+            throw new ConnectionException($error . ' ' . $diagnostic_message);
         }
 
         $this->bound = true;
diff --git a/src/Symfony/Component/Ldap/CHANGELOG.md b/src/Symfony/Component/Ldap/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+7.1
+---
+
+ * Improve error reporting during LDAP bind
+
 7.0
 ---
 

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,8 @@ public function bind(?string $dn = null, #[\SensitiveParameter] ?string $passwor`
`78`	`78`	`case self::LDAP_ALREADY_EXISTS:`
`79`	`79`	`throw new AlreadyExistsException($error);`
`80`	`80`	`}`
`81`		`- throw new ConnectionException($error);`
	`81`	`+ ldap_get_option($this->connection, LDAP_OPT_DIAGNOSTIC_MESSAGE, $diagnostic_message);`
	`82`	`+ throw new ConnectionException($error . ' ' . $diagnostic_message);`
`82`	`83`	`}`
`83`	`84`
`84`	`85`	`$this->bound = true;`